mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #1922] 0.23.0 release planning #815
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#815
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @djc on GitHub (Apr 26, 2023).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1922
Just getting this started to help people track what's blocking the release.
@bluejekyll what are we waiting for?
I'll nominate:
Would be good to get some feedback at least on #1919moved to #2008@bluejekyll commented on GitHub (Apr 26, 2023):
I was thinking maybe we could just release a prerelease version, and just start getting that in the wild?
@djc commented on GitHub (Apr 26, 2023):
Yup, getting an alpha or beta out is usually a good way to enable downstream consumers, and will help us gather more feedback for the release too.
@glts commented on GitHub (May 8, 2023):
Please include an updated enum-as-inner dependency in 0.23.
enum-as-inner 0.5.1 is the only remaining dependency in
trust-dns-resolver whose syn dependency is still at version 1. All other
dependencies transitively include syn 2.
It would be great if for the next release of trust-dns-resolver an
updated enum-as-inner could be included, in order to eliminate any
transitive dependency on syn 1.
@djc commented on GitHub (May 8, 2023):
enum-as-inner 0.5.1 is semver-compatible with 0.5 (which we're already using on main) so for library usage this should be covered already (the
Cargo.lockfile is largely irrelevant here).@glts commented on GitHub (May 8, 2023):
@djc Agreed. Nevertheless, 0.23 might be a good occasion to include a version of enum-as-inner that depends on syn 2, eg for those who want to try to build something with 'minimal dependency versions' ...
@djc commented on GitHub (May 8, 2023):
So you're set on getting something that can satisfy minimal versions without pulling in syn 1? That seems extremely niche.
@glts commented on GitHub (May 8, 2023):
All right, let's drop it.
@peterthejohnston commented on GitHub (May 12, 2023):
Thanks for putting out an alpha release! I noticed that the v0.23.0-alpha.1 version doesn't seem to appear on crates.io: https://crates.io/crates/trust-dns-resolver/versions
Is that intentional? (Maybe there is a delay between the GitHub release and it ending up on crates.io?) It would be great if it could be released there so we can pull it in and do some early testing to prepare for v0.23.0.
@cpu commented on GitHub (May 12, 2023):
@peterthejohnston In a comment on another PR @bluejekyll mentioned there was a hiccup publishing that release. I think there's a plan to publish a replacement.
@bluejekyll commented on GitHub (May 12, 2023):
yeah, I'm working on it. Something changed in the publish command in cargo-make, it's just delayed me getting this out. I'll publish manually today. Not sure why that auto-publish broke, but something about the workspace crate ordering changed, and I'm not sure why.
@djc commented on GitHub (May 12, 2023):
Maybe the addition of the fuzz crate (which probably shouldn't be published)?
@bluejekyll commented on GitHub (May 12, 2023):
I think it's excluded, but from the logs on github it looks like
bintried to be published first and I don't know why that is (honestly I wrote this so long ago and it's been working fine, I can't remember how I got the crates to publish in the correct order in the first place)@bluejekyll commented on GitHub (May 12, 2023):
ok, alpha.2 should now be published. I couldn't get the cargo-make script to work properly... I still need to debug that.
@djc commented on GitHub (May 12, 2023):
"should not be" -> "should now be" (I can see trust-dns-proto is up on crates.io).
@bluejekyll commented on GitHub (May 12, 2023):
fixed, that's a typo that makes it 100% have a different meaning.
@mokeyish commented on GitHub (May 12, 2023):
A question I have: Is
cargo-makereally needed?If you need to define a build workflow, justfile is also a good choice, like makefile, but cross-platform.
I’m not familiar with cargo-make, it’s not as intuitive as makefile, justfule is just for reference.
@bluejekyll commented on GitHub (May 12, 2023):
one of the nice things that cargo-make does that always makes me hesitant to switch is decent support for workspaces and building patterns related to them. I have been thinking of moving everything over to justfiles, but having deeper integration with cargo is a really nice feature of cargo-make.
@bluejekyll commented on GitHub (May 15, 2023):
Ok, I think
cargo-workspaceshas all the functionality I need pretty much. I'm thinking of converting to justfiles in combination with that tool. If anyone has any other suggestions there, I'll use this issue: #1934@jeff-hiner commented on GitHub (May 15, 2023):
@djc Sorry it's taken me so long to get to this, but there are some structural issues with
AbstractNameServer. It's easier to use than what was replaced, so I do suggest we move forward... but we need to break apart the types forDnsHandleandCreateConnection. I can't realistically create a single type that implements both.To me the intent is
CreateConnectionis a factory that producesDnsHandle. The factory for a DoH provider doesn't get config information untilnew_connectionis called. And aCreateConnectionfactory by itself without that information can't handlesendrequests.@XOR-op commented on GitHub (May 20, 2023):
Since #1938 tries to solve the problem @jeff-hiner mentions, I suggest to add this to the list until it's accepted or rejected.
@djc commented on GitHub (May 22, 2023):
Added it to the list.
@mattias-p commented on GitHub (Aug 21, 2023):
What's the current status of 0.23.0? It's been three months and three alphas since the last update here. Also, is there anything I could do to help out?
@djc commented on GitHub (Aug 22, 2023):
@bluejekyll do you have a plan for this? What's blocking the release? I do think we should get a release out soon even if only to get rustls 0.21 which most of the ecosystem has picked up.
@bluejekyll commented on GitHub (Aug 22, 2023):
Yeah, we can do that. I haven't seen any negative issues filed on the alpha's...
@bluejekyll commented on GitHub (Aug 22, 2023):
@djc, want to cross out the items in your list above that are not in the 0.23 release?
@bluejekyll commented on GitHub (Aug 22, 2023):
ok, it would be great if we could land #2001, #2003, #2004, and #2005 as they will have breaking changes to APIs. But they are large changes, #2001 especially. So we could push the 0.23 release and then follow closely with 0.24. Anyone have thoughts?
@XOR-op commented on GitHub (Aug 22, 2023):
I think we should not push too many breaking changes at once, where users may find too many modifications they should perform after one incompatible version upgrade. IMO a closely followed 0.24 is better than a super big 0.23, since the upgrade path is smoother.
@bluejekyll commented on GitHub (Aug 22, 2023):
I'll start preparing the 0.23 release now. If anyone has objections, please raise them here.
@bluejekyll commented on GitHub (Aug 22, 2023):
#2007 will be the 0.23.0 release.
@bluejekyll commented on GitHub (Aug 22, 2023):
Ok, once this job is done, 0.23 will be released: https://github.com/bluejekyll/trust-dns/actions/runs/5941553830
I think we should probably close this issue, and carry forward open items to 0.24.
@bluejekyll commented on GitHub (Aug 22, 2023):
see #2008 for any carried over work