[PR #1058] [MERGED] Properly reuse connections, for TCP, TLS, and HTTPS #1934

New issue

Closed

opened 2026-03-16 03:59:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 03:59:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1058
Author: @bluejekyll
Created: 4/5/2020
Status: ✅ Merged
Merged: 4/7/2020
Merged by: @bluejekyll

Base: master ← Head: fix-connection-reuse

📝 Commits (4)

691c1aa add test to detect when NameServer not reused
c275e06 correctly track single reference to Client in NameServer
cd0cece bump openssl on Windows to 1_1_1f
1ea9f34 remove read-write lock on name_server_state

📊 Changes

6 files changed (+263 additions, -89 deletions)

View changed files

📝 Makefile.toml (+1 -1)
📝 crates/https/src/https_client_stream.rs (+30 -9)
📝 crates/resolver/src/https.rs (+19 -0)
📝 crates/resolver/src/name_server/name_server.rs (+29 -15)
📝 crates/resolver/src/name_server/name_server_pool.rs (+110 -1)
📝 crates/resolver/src/name_server/name_server_state.rs (+74 -63)

📄 Description

fixes: #1043
Fixes: #989

@balboah, I think this fixes the issue you discovered.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1058 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 4/5/2020 **Status:** ✅ Merged **Merged:** 4/7/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix-connection-reuse` --- ### 📝 Commits (4) - [`691c1aa`](https://github.com/hickory-dns/hickory-dns/commit/691c1aa9eb2c53cd0ab38ee28742d96b2c4ad8a3) add test to detect when NameServer not reused - [`c275e06`](https://github.com/hickory-dns/hickory-dns/commit/c275e06de972d95d192b46f6642b146dbc069472) correctly track single reference to Client in NameServer - [`cd0cece`](https://github.com/hickory-dns/hickory-dns/commit/cd0cece8e0027f5b83c9128065b7878707684196) bump openssl on Windows to 1_1_1f - [`1ea9f34`](https://github.com/hickory-dns/hickory-dns/commit/1ea9f344624b20377d916ac91b195b706f402d2b) remove read-write lock on name_server_state ### 📊 Changes **6 files changed** (+263 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.toml` (+1 -1) 📝 `crates/https/src/https_client_stream.rs` (+30 -9) 📝 `crates/resolver/src/https.rs` (+19 -0) 📝 `crates/resolver/src/name_server/name_server.rs` (+29 -15) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+110 -1) 📝 `crates/resolver/src/name_server/name_server_state.rs` (+74 -63) </details> ### 📄 Description fixes: #1043 Fixes: #989 @balboah, I think this fixes the issue you discovered. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>