[PR #1067] [MERGED] Async std support #1938

New issue

Closed

opened 2026-03-16 04:00:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 04:00:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1067
Author: @bluejekyll
Created: 4/9/2020
Status: ✅ Merged
Merged: 4/11/2020
Merged by: @bluejekyll

Base: master ← Head: async-std-support

📝 Commits (6)

634269c Add basic support for async_std resolver
23fb5bd Add async-std support to CI
b9d6a77 add separate crate for AsyncStd
405fbfb port over all tests
804d7a9 update crates.io information
e4a9059 cleanup some feature based build params

📊 Changes

16 files changed (+1136 additions, -90 deletions)

View changed files

📝 .github/workflows/test.yml (+5 -5)
📝 CHANGELOG.md (+1 -0)
📝 Cargo.lock (+227 -70)
📝 Cargo.toml (+1 -0)
📝 Makefile.toml (+17 -10)
➕ crates/async-std-resolver/Cargo.toml (+74 -0)
➕ crates/async-std-resolver/LICENSE-APACHE (+202 -0)
➕ crates/async-std-resolver/LICENSE-MIT (+20 -0)
➕ crates/async-std-resolver/README.md (+58 -0)
➕ crates/async-std-resolver/src/lib.rs (+129 -0)
➕ crates/async-std-resolver/src/net.rs (+81 -0)
➕ crates/async-std-resolver/src/runtime.rs (+86 -0)
➕ crates/async-std-resolver/src/tests.rs (+201 -0)
➕ crates/async-std-resolver/src/time.rs (+31 -0)
📝 crates/proto/src/udp/udp_stream.rs (+2 -5)
📝 crates/resolver/src/async_resolver.rs (+1 -0)

📄 Description

This adds async std support, but as a separate crate in an attempt to not end up with crazy feature confusion for downstream dependencies. This is based off of #1051

FYI @belak

@briansmith, I think this provides a blueprint for the way to implement resolvers for different runtimes.

Fixes: #926
Closes: #1051

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1067 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 4/9/2020 **Status:** ✅ Merged **Merged:** 4/11/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `async-std-support` --- ### 📝 Commits (6) - [`634269c`](https://github.com/hickory-dns/hickory-dns/commit/634269c22426fbfb49c154b4e67478f2d0e804ac) Add basic support for async_std resolver - [`23fb5bd`](https://github.com/hickory-dns/hickory-dns/commit/23fb5bdaab4d90c39736058f97787d86c1bfbf5f) Add async-std support to CI - [`b9d6a77`](https://github.com/hickory-dns/hickory-dns/commit/b9d6a770b6032801d0349437235739037055cb86) add separate crate for AsyncStd - [`405fbfb`](https://github.com/hickory-dns/hickory-dns/commit/405fbfb99a7866d9a1f47d8ca519838d191d46f6) port over all tests - [`804d7a9`](https://github.com/hickory-dns/hickory-dns/commit/804d7a9b4322ec5641cd34c67dea7990ac9e11e7) update crates.io information - [`e4a9059`](https://github.com/hickory-dns/hickory-dns/commit/e4a9059c3b8fa53f957cbe0e10ed231b8133454e) cleanup some feature based build params ### 📊 Changes **16 files changed** (+1136 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+5 -5) 📝 `CHANGELOG.md` (+1 -0) 📝 `Cargo.lock` (+227 -70) 📝 `Cargo.toml` (+1 -0) 📝 `Makefile.toml` (+17 -10) ➕ `crates/async-std-resolver/Cargo.toml` (+74 -0) ➕ `crates/async-std-resolver/LICENSE-APACHE` (+202 -0) ➕ `crates/async-std-resolver/LICENSE-MIT` (+20 -0) ➕ `crates/async-std-resolver/README.md` (+58 -0) ➕ `crates/async-std-resolver/src/lib.rs` (+129 -0) ➕ `crates/async-std-resolver/src/net.rs` (+81 -0) ➕ `crates/async-std-resolver/src/runtime.rs` (+86 -0) ➕ `crates/async-std-resolver/src/tests.rs` (+201 -0) ➕ `crates/async-std-resolver/src/time.rs` (+31 -0) 📝 `crates/proto/src/udp/udp_stream.rs` (+2 -5) 📝 `crates/resolver/src/async_resolver.rs` (+1 -0) </details> ### 📄 Description This adds async std support, but as a separate crate in an attempt to not end up with crazy feature confusion for downstream dependencies. This is based off of #1051 FYI @belak @briansmith, I think this provides a blueprint for the way to implement resolvers for different runtimes. Fixes: #926 Closes: #1051 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>