[PR #1141] [MERGED] No more master slave, in honor of Juneteenth #2003

New issue

Closed

opened 2026-03-16 04:24:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 04:24:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1141
Author: @bluejekyll
Created: 6/19/2020
Status: ✅ Merged
Merged: 6/20/2020
Merged by: @bluejekyll

Base: main ← Head: not-master-slave

📝 Commits (6)

a9ca5cc in honor of Juneteenth, remove replace Master with Primary
75122de in honor of Juneteenth, remove replace Slave with Secondary
5d1ae3d add 8499 for reference about naming
3047004 clean up deprecation warnings
1a1e701 remove unsupported markdown strikethroughs...
ded250c revert primary to master in BIND compatibility tests

📊 Changes

48 files changed (+225 additions, -201 deletions)

View changed files

📝 CHANGELOG.md (+3 -3)
📝 README.md (+3 -1)
📝 bin/benches/bind_conf/example.conf (+6 -6)
📝 crates/client/src/client/async_client.rs (+29 -29)
📝 crates/client/src/client/client.rs (+17 -17)
📝 crates/client/src/op/update_message.rs (+17 -17)
📝 crates/client/src/serialize/txt/mod.rs (+5 -5)
📝 crates/client/src/serialize/txt/rdata_parsers/openpgpkey.rs (+1 -1)
📝 crates/client/src/serialize/txt/zone.rs (+9 -9)
📝 crates/client/src/serialize/txt/zone_lex.rs (+0 -0)
📝 crates/proto/src/op/message.rs (+1 -1)
📝 crates/proto/src/rr/rdata/a.rs (+1 -1)
📝 crates/proto/src/rr/rdata/null.rs (+1 -1)
📝 crates/proto/src/rr/rdata/opt.rs (+1 -1)
📝 crates/proto/src/rr/rdata/soa.rs (+4 -4)
📝 crates/proto/src/rr/record_data.rs (+3 -3)
📝 crates/server/src/authority/catalog.rs (+22 -9)
📝 crates/server/src/authority/message_request.rs (+1 -1)
📝 crates/server/src/authority/zone_type.rs (+10 -2)
📝 crates/server/src/config/mod.rs (+1 -1)

...and 28 more files

📄 Description

Fixes: #1139

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1141 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 6/19/2020 **Status:** ✅ Merged **Merged:** 6/20/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `not-master-slave` --- ### 📝 Commits (6) - [`a9ca5cc`](https://github.com/hickory-dns/hickory-dns/commit/a9ca5cc671f585ec37ed5096add780f39fe371c3) in honor of Juneteenth, remove replace Master with Primary - [`75122de`](https://github.com/hickory-dns/hickory-dns/commit/75122de017e7251a6a5c6aaa0724dffe98750ce7) in honor of Juneteenth, remove replace Slave with Secondary - [`5d1ae3d`](https://github.com/hickory-dns/hickory-dns/commit/5d1ae3d0e708732e3c0606140c7ea28fcc9c854a) add 8499 for reference about naming - [`3047004`](https://github.com/hickory-dns/hickory-dns/commit/3047004836df44d9b7d5b6f270f290d848eed646) clean up deprecation warnings - [`1a1e701`](https://github.com/hickory-dns/hickory-dns/commit/1a1e7014df862602fca4f2e21b8bc87d6aa43883) remove unsupported markdown strikethroughs... - [`ded250c`](https://github.com/hickory-dns/hickory-dns/commit/ded250caa0383ec18552373cd16cfd50b3b12d8a) revert primary to master in BIND compatibility tests ### 📊 Changes **48 files changed** (+225 additions, -201 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -3) 📝 `README.md` (+3 -1) 📝 `bin/benches/bind_conf/example.conf` (+6 -6) 📝 `crates/client/src/client/async_client.rs` (+29 -29) 📝 `crates/client/src/client/client.rs` (+17 -17) 📝 `crates/client/src/op/update_message.rs` (+17 -17) 📝 `crates/client/src/serialize/txt/mod.rs` (+5 -5) 📝 `crates/client/src/serialize/txt/rdata_parsers/openpgpkey.rs` (+1 -1) 📝 `crates/client/src/serialize/txt/zone.rs` (+9 -9) 📝 `crates/client/src/serialize/txt/zone_lex.rs` (+0 -0) 📝 `crates/proto/src/op/message.rs` (+1 -1) 📝 `crates/proto/src/rr/rdata/a.rs` (+1 -1) 📝 `crates/proto/src/rr/rdata/null.rs` (+1 -1) 📝 `crates/proto/src/rr/rdata/opt.rs` (+1 -1) 📝 `crates/proto/src/rr/rdata/soa.rs` (+4 -4) 📝 `crates/proto/src/rr/record_data.rs` (+3 -3) 📝 `crates/server/src/authority/catalog.rs` (+22 -9) 📝 `crates/server/src/authority/message_request.rs` (+1 -1) 📝 `crates/server/src/authority/zone_type.rs` (+10 -2) 📝 `crates/server/src/config/mod.rs` (+1 -1) _...and 28 more files_ </details> ### 📄 Description Fixes: #1139 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>