[PR #1051] [CLOSED] Initial async-std support #1922

New issue

Closed

opened 2026-03-16 03:43:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 03:43:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1051
Author: @belak
Created: 3/26/2020
Status: ❌ Closed

Base: master ← Head: async-std

📝 Commits (2)

315bd34 Add basic support for async_std resolver
1c1a80a Add async-std support to CI

📊 Changes

11 files changed (+321 additions, -13 deletions)

View changed files

📝 .github/workflows/test.yml (+5 -5)
📝 Cargo.lock (+137 -0)
📝 Makefile.toml (+8 -2)
📝 crates/proto/Cargo.toml (+2 -0)
📝 crates/proto/src/lib.rs (+62 -0)
📝 crates/proto/src/tcp/tcp_client_stream.rs (+15 -2)
📝 crates/proto/src/udp/udp_stream.rs (+17 -4)
📝 crates/resolver/Cargo.toml (+2 -0)
📝 crates/resolver/src/async_resolver.rs (+39 -0)
📝 crates/resolver/src/name_server/connection_provider.rs (+29 -0)
📝 crates/resolver/src/name_server/mod.rs (+5 -0)

📄 Description

Please note that is meant mostly as a PoC. As far as I can tell, the tests are hard-coded to use tokio in most cases.

I'm happy to spend a bit more time to get this across the finish line if requested, but I'm relatively new to both async_std and rust, so I could use some guidance, specifically around tests.

Also note that 7ee111b is from my other PR, but can be removed if that doesn't go in.

This would fix #926

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1051 **Author:** [@belak](https://github.com/belak) **Created:** 3/26/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `async-std` --- ### 📝 Commits (2) - [`315bd34`](https://github.com/hickory-dns/hickory-dns/commit/315bd3434f292fd30d98d6884500dfc372ce6ce8) Add basic support for async_std resolver - [`1c1a80a`](https://github.com/hickory-dns/hickory-dns/commit/1c1a80a90ff48b56a2255cd2b9199218b3c6eb41) Add async-std support to CI ### 📊 Changes **11 files changed** (+321 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+5 -5) 📝 `Cargo.lock` (+137 -0) 📝 `Makefile.toml` (+8 -2) 📝 `crates/proto/Cargo.toml` (+2 -0) 📝 `crates/proto/src/lib.rs` (+62 -0) 📝 `crates/proto/src/tcp/tcp_client_stream.rs` (+15 -2) 📝 `crates/proto/src/udp/udp_stream.rs` (+17 -4) 📝 `crates/resolver/Cargo.toml` (+2 -0) 📝 `crates/resolver/src/async_resolver.rs` (+39 -0) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+29 -0) 📝 `crates/resolver/src/name_server/mod.rs` (+5 -0) </details> ### 📄 Description Please note that is meant mostly as a PoC. As far as I can tell, the tests are hard-coded to use tokio in most cases. I'm happy to spend a bit more time to get this across the finish line if requested, but I'm relatively new to both async_std and rust, so I could use some guidance, specifically around tests. Also note that 7ee111b is from my other PR, but can be removed if that doesn't go in. This would fix #926 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>