mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #455] [FEATURE] scribe.rip alternative to medium.com #298
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#298
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @benbusby on GitHub (Oct 12, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/455
Describe the feature you'd like to see added
Allow scribe.rip to replace all
medium.comand*.medium.comresultsAdditional context
Should function the same as
twitter.com->nitter.net,instagram.com->bibliogram.art/u, etc, but with the exception that it needs to replace the full domain (including subdomain) for every matching result, not just themedium.comportion.@benbusby commented on GitHub (Oct 12, 2021):
Anyone interested contributing for hacktoberfest (or otherwise just wanting to contribute) -- this should be a pretty easy issue to tackle that adds a lot of value.
The main things to do would be:
app/utils/results.py -> get_site_alt()to useurlparse(...).hostnameto replace the domain path (rather than just doing a simple hardcoded string replacement) in order to encapsulate subdomains as well.WHOOGLE_ALT_MDenv var, or something similar.If interested, please assign yourself this issue to mark that it's in progress and open a PR once it's finished. Otherwise I'll likely end up tackling this fairly soon (as I often get frustrated with the Medium paywalls).
@vacom13 commented on GitHub (Oct 13, 2021):
I am interested in contributing. Could you guide me as I am fairly new to all this?
@benbusby commented on GitHub (Oct 14, 2021):
@vacom13 New to the project itself? Or new to contributing on github?
Either way, this feature would involve these changes:
Updating the
get_site_alt()method inapp/utils/results.pywith something like the following:Haven't tested that, but should work. Then updating the
SITE_ALTSmapping in the same class to include amedium.comthat maps to aWHOOGLE_ALT_MDenvironment variable or something like that with a default value ofscribe.rip.You'd also need to update the documentation in the README with the new environment variable name and purpose, and include it in
whoogle.env, the Dockerfile,app.json, anddocker-compose.yml. It sounds like a lot but it's all pretty quick copy/paste stuff based on existing environment variables that you can reference likeWHOOGLE_ALT_TWandWHOOGLE_ALT_IG.Let me know if this makes sense. Happy to help further if needed!
@vacom13 commented on GitHub (Oct 14, 2021):
Well I am new to github. Just came across this rep. Felt maybe should try to contribute to it. Thank you. I will work on it!
@vacom13 commented on GitHub (Oct 15, 2021):
Hey @benbusby. I created a PR. Would love to contribute more. Tell me if there is anything more that I could do. I want to help and learn along the way.
@benbusby commented on GitHub (Oct 15, 2021):
Awesome. I'll review the PR this weekend and let you know if there's anything else needed. Thanks for taking care of this!
@benbusby commented on GitHub (Oct 16, 2021):
Merged via #463 -- thanks again @vacom13, great work.
I'm slowly trying to mark the more straightforward issues with the label "good first issue". Keep an eye out for those and let me know if you want to contribute to any that you see.
@vacom13 commented on GitHub (Oct 16, 2021):
@benbusby Sure thing!