mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #721] bug with session expire,redirects,http,mayby my fault? don't know #463
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#463
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DEvmIb on GitHub (Apr 15, 2022).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/721
Describe the bug
2.1 same when enter search in searchbox and enter
Deployment Method
runexecutableVersion of Whoogle Search
Desktop (please complete the following information):
firefox 99.0
Additional context
HTTPS_ONLY=0 or HTTPS_ONLY=1 makes no difference
WHOOGLE_CONFIG_URL ist set to https://whoogle.example.com/
WHOOGLE_CONFIG_GET_ONLY=1 works
whoogle seems to give me (after expire old session?) new one and using http://
is this session stuff needed? why not just using cookies?
@kodekebles commented on GitHub (Apr 23, 2022):
Literally just registered to report this. I'm experiencing the exact behavior with an entirely different stack, namely using docker, through nginx via caprover. It appears to be same thing you're reporting, firefox POSTs to the HTTP site, it 307 redirects to the HTTPS version including the session ID URI but while forcing the cookies to expire? (i'm a layman forgive if that's incorrect, but during one of the redirects it appears to be setting a cookie that expires 1970, which i assume is just to force expire it), then 307 to /search (where it's expecting you to have POSTed a query) and you just get dumped back to the index because there's no data.
One mitigation I just found is that enabling HTTPS-only mode in firefox seems to allow it to work by virtue of just submitting the original request via HTTPS.
Honestly, could this be chalked up to a firefox "issue" or just odd behavior maybe? Should it not generally attempt to connect via HTTPS to search engines in the first place? I think that expectation is what confused me the most about this. But I'm generally fine with HTTPS-only mode on anyway, but it'd still be nice if this were worked around or documented somewhere.
@nakoo commented on GitHub (May 1, 2022):
I believe this issue has been fixed by adding
X-Forwarded-Protoheader.Have you still suffered the issue?
https://github.com/benbusby/whoogle-search/pull/731