[PR #535] [MERGED] Improve rendering of the tabs #907

New issue

Closed

opened 2026-02-25 20:37:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:37:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/benbusby/whoogle-search/pull/535
Author: @jacr13
Created: 11/17/2021
Status: ✅ Merged
Merged: 2/7/2022
Merged by: @benbusby

Base: main ← Head: dev-header-tabs

📝 Commits (10+)

c4edbad add default content for tabs
fb4a135 add translation for english only
dd5321a add function that updates default content
527ca25 add full_query to the class attributs
597847d change default imageresults template
0adbb23 update header.html with tabs
3f2d395 load default header tabs content
6df326f render header with tabs
bcdf557 add styling to header
b1b9f6a remove existing tabs form raw response

📊 Changes

14 files changed (+821 additions, -138 deletions)

View changed files

📝 app/__init__.py (+3 -0)
📝 app/filter.py (+51 -15)
➕ app/models/g_classes.py (+16 -0)
📝 app/routes.py (+14 -7)
📝 app/static/css/dark-theme.css (+5 -0)
📝 app/static/css/header.css (+115 -0)
📝 app/static/css/light-theme.css (+6 -0)
📝 app/static/css/search.css (+12 -1)
➕ app/static/settings/header_tabs.json (+38 -0)
📝 app/static/settings/translations.json (+112 -16)
📝 app/templates/header.html (+43 -5)
📝 app/templates/imageresults.html (+368 -94)
📝 app/utils/results.py (+37 -0)
📝 app/utils/search.py (+1 -0)

📄 Description

The rendering is similar in all the tabs.

In addition, the tab disposition is the same across all the tabs.

If the translation is not present, the default names will be displayed (in English), some effort needs to be made here to add translation for all supported languages. It shouldn't be very hard to translate since they are very basic words.

This probably fixes #298. I intentionally removed the shopping tab because it requires some effort to render correctly (#136).

The header should be extended to add an extra row with different parameters to choice from (#322 and possibly #192)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/benbusby/whoogle-search/pull/535 **Author:** [@jacr13](https://github.com/jacr13) **Created:** 11/17/2021 **Status:** ✅ Merged **Merged:** 2/7/2022 **Merged by:** [@benbusby](https://github.com/benbusby) **Base:** `main` ← **Head:** `dev-header-tabs` --- ### 📝 Commits (10+) - [`c4edbad`](https://github.com/benbusby/whoogle-search/commit/c4edbad652df0deeb0ecf8900f126eae2b16f327) add default content for tabs - [`fb4a135`](https://github.com/benbusby/whoogle-search/commit/fb4a1351c24f5a132740dc000c70b2d98976bf42) add translation for english only - [`dd5321a`](https://github.com/benbusby/whoogle-search/commit/dd5321ae7ced610a14547991af8f215955acd67b) add function that updates default content - [`527ca25`](https://github.com/benbusby/whoogle-search/commit/527ca25300bd21edf71349eb296e4ae1d1901627) add full_query to the class attributs - [`597847d`](https://github.com/benbusby/whoogle-search/commit/597847d38822dae2905b74a3c6d728ffc83efb0a) change default imageresults template - [`0adbb23`](https://github.com/benbusby/whoogle-search/commit/0adbb23a1fee9d8c95d4ec25d68864034b291a93) update header.html with tabs - [`3f2d395`](https://github.com/benbusby/whoogle-search/commit/3f2d3952fd264873311bdd7ae3ce41534fe6c0ad) load default header tabs content - [`6df326f`](https://github.com/benbusby/whoogle-search/commit/6df326ff06f7dadabc0207ef60222c06d6691d83) render header with tabs - [`bcdf557`](https://github.com/benbusby/whoogle-search/commit/bcdf5578eb4791e738118d833f27706d468f693f) add styling to header - [`b1b9f6a`](https://github.com/benbusby/whoogle-search/commit/b1b9f6a0e99c685b14c56ceb1dc3c4d427e4b27b) remove existing tabs form raw response ### 📊 Changes **14 files changed** (+821 additions, -138 deletions) <details> <summary>View changed files</summary> 📝 `app/__init__.py` (+3 -0) 📝 `app/filter.py` (+51 -15) ➕ `app/models/g_classes.py` (+16 -0) 📝 `app/routes.py` (+14 -7) 📝 `app/static/css/dark-theme.css` (+5 -0) 📝 `app/static/css/header.css` (+115 -0) 📝 `app/static/css/light-theme.css` (+6 -0) 📝 `app/static/css/search.css` (+12 -1) ➕ `app/static/settings/header_tabs.json` (+38 -0) 📝 `app/static/settings/translations.json` (+112 -16) 📝 `app/templates/header.html` (+43 -5) 📝 `app/templates/imageresults.html` (+368 -94) 📝 `app/utils/results.py` (+37 -0) 📝 `app/utils/search.py` (+1 -0) </details> ### 📄 Description The rendering is similar in all the tabs. In addition, the tab disposition is the same across all the tabs. If the translation is not present, the default names will be displayed (in English), some effort needs to be made here to add translation for all supported languages. It shouldn't be very hard to translate since they are very basic words. This probably fixes #298. I intentionally removed the shopping tab because it requires some effort to render correctly (#136). The header should be extended to add an extra row with different parameters to choice from (#322 and possibly #192) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>