mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #303] failed to save bookmark: title must not be empty (500) #221
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#221
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sbrl on GitHub (Apr 4, 2021).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/303
If the title (which is apparently optional) is not set when adding a bookmark, it generates the following error:
Here's a screenshot:
It doesn't matter whether the archive option is ticked or not.
@fmartingr commented on GitHub (Feb 10, 2022):
Hey @sbrl, I've just tried this and it works without an issue. I'm closing as can't reproduce. If you still experience this issue please share the link you're trying to save to investigate further.
@sbrl commented on GitHub (Feb 18, 2022):
That's weird - I can reproduce this for all webpages @fmartingr.
For reference, I'm using this Dockerfile I've written on a Raspberry Pi 4 in armv7l mode, with this
run.shscript.@fmartingr commented on GitHub (Feb 18, 2022):
Hey @sbrl , which database are you using? (assuming sqlite). Have you tried with the latests commits from master?
I've checked and the bookmark should arrive to the save portion without a title (at least from the API, which is what the frontend uses):
github.com/go-shiori/shiori@feb150f8c6/internal/webserver/handler-api.go (L303-L306)@sbrl commented on GitHub (May 1, 2022):
Oops, sorry for not responding.
Yeah, I am using sqlite. Hmmmm, I'll give the latest release a go - I've just compiled and run the migration tool, so I'm now rebuilding my Docker image. I'll report back here when it's done.
@sbrl commented on GitHub (May 1, 2022):
Ok, so in the latest stable version it sorta works, in that it doesn't throw an error anymore, but it also doesn't fetch the title automatically:
It also takes forever to load the page as well, where it didn't before (but that's probably a separate issue).
@fmartingr commented on GitHub (May 26, 2022):
That is expected, the bookmark is added faster and the content retrieval is performed in the background. If you refresh after a few seconds the content should be there.
Sorry about that! This is being discussed in #408
@stale[bot] commented on GitHub (Nov 5, 2022):
This issue has been automatically marked as stale because it has not had any activity for quite some time.
It will be closed if no further activity occurs.
Thank you for your contributions.