starred/shiori

Fork 0

mirror of https://github.com/go-shiori/shiori.git synced 2026-04-25 06:25:54 +03:00

[GH-ISSUE #899] Search API Fails to Return Results for Multi-Keyword Queries #408

New issue

Open

opened 2026-02-25 23:34:09 +03:00 by kerem · 4 comments

kerem commented

2026-02-25 23:34:09 +03:00

Owner

Originally created by @DesarrolloAntonio on GitHub (May 2, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/899

Data

Shiori version: 1.6.3

Describe the bug / actual behavior

When performing a search on the API with a single keyword, results are returned as expected. However, adding a second keyword results in an empty response list.

Expected behavior

I expect the search to return results that match both keywords.

To Reproduce

1 - I have a bookmark with this value, title":"Kotlin Design Patterns: Observer Explained | ProAndroidDev"
2 - With this endpoint (http://192.168.1.26:18080/api/bookmarks?page=1&keyword=kotlin) returns the correct elements
3 - With this endpoint (http://192.168.1.26:18080/api/bookmarks?page=1&keyword=kotlin%20Design) returns an empty list

Originally created by @DesarrolloAntonio on GitHub (May 2, 2024). Original GitHub issue: https://github.com/go-shiori/shiori/issues/899 ## Data Shiori version: 1.6.3 ## Describe the bug / actual behavior When performing a search on the API with a single keyword, results are returned as expected. However, adding a second keyword results in an empty response list. ## Expected behavior I expect the search to return results that match both keywords. ## To Reproduce 1 - I have a bookmark with this value, title":"Kotlin Design Patterns: Observer Explained | ProAndroidDev" 2 - With this endpoint (http://192.168.1.26:18080/api/bookmarks?page=1&keyword=kotlin) returns the correct elements 3 - With this endpoint (http://192.168.1.26:18080/api/bookmarks?page=1&keyword=kotlin%20Design) returns an empty list

kerem added the

type:bug

label

2026-02-25 23:34:09 +03:00

kerem commented

2026-02-25 23:34:09 +03:00

Author

Owner

@Monirzadeh commented on GitHub (May 2, 2024):

just for add more data after a quick test:
search can't return Kotlin De but return result for this Kotlin Design 🤔

@Monirzadeh commented on GitHub (May 2, 2024): just for add more data after a quick test: search can't return `Kotlin De` but return result for this `Kotlin Design` :thinking:

kerem commented

2026-02-25 23:34:09 +03:00

Author

Owner

@DesarrolloAntonio commented on GitHub (May 2, 2024):

just for add more data after a quick test: search can't return Kotlin De but return result for this Kotlin Design 🤔

With "kotlin Design" works

@DesarrolloAntonio commented on GitHub (May 2, 2024): > just for add more data after a quick test: search can't return `Kotlin De` but return result for this `Kotlin Design` 🤔 With "kotlin Design" works

kerem commented

2026-02-25 23:34:09 +03:00

Author

Owner

@Monirzadeh commented on GitHub (May 2, 2024):

just for add more data after a quick test: search can't return Kotlin De but return result for this Kotlin Design 🤔

With "kotlin Design" works

we change the logic of search a little in #721. as i remember searching is case insensitive so it return the result. maybe this need improvement but first we should solve current issue.
@fmartingr you work on that part of code more than me. do you have any idea? somehow it just search for text that separate with space..

@Monirzadeh commented on GitHub (May 2, 2024): > > just for add more data after a quick test: search can't return `Kotlin De` but return result for this `Kotlin Design` 🤔 > > With "kotlin Design" works we change the logic of search a little in #721. as i remember searching is case insensitive so it return the result. maybe this need improvement but first we should solve current issue. @fmartingr you work on that part of code more than me. do you have any idea? somehow it just search for text that separate with space..

kerem commented

2026-02-25 23:34:09 +03:00

Author

Owner

@fmartingr commented on GitHub (May 18, 2024):

As with a lot of other things, searching needs to be revisited at some point. I have been tempted to use bleve but that would make twice the storage for the same amount of bookmarks. Each database engine would need to have it's own Search method with SearchOptions passed from the query. I will fill in a proper issue when I sit down and think about it, there's just too many things to work on 😓

@fmartingr commented on GitHub (May 18, 2024): As with a lot of other things, searching needs to be revisited at some point. I have been tempted to use bleve but that would make twice the storage for the same amount of bookmarks. Each database engine would need to have it's own `Search` method with `SearchOptions` passed from the query. I will fill in a proper issue when I sit down and think about it, there's just too many things to work on 😓

kerem referenced this issue

2026-02-25 23:34:50 +03:00

[PR #425] [MERGED] Improve performance for sqlite queries #592