[PR #221] [MERGED] Fix login autofill #538

New issue

Closed

opened 2026-02-25 23:34:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/221
Author: @deanishe
Created: 12/13/2019
Status: ✅ Merged
Merged: 8/6/2020
Merged by: @deanishe

Base: master ← Head: fix/autofill

📝 Commits (1)

a5cb2c6 Fix login autofill

📊 Changes

2 files changed (+88 additions, -82 deletions)

View changed files

📝 internal/view/login.html (+26 -20)
📝 internal/webserver/assets-prod.go (+62 -62)

📄 Description

Add <form> element, as some browsers won't autofill fields not contained in a form. Fixes #222

Remove username and password bindings, and explicitly read inputs on login instead. Some browsers do not fire onChange events when a field is autofilled for security reasons, so Vue bindings don't register the change.

More info.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/221 **Author:** [@deanishe](https://github.com/deanishe) **Created:** 12/13/2019 **Status:** ✅ Merged **Merged:** 8/6/2020 **Merged by:** [@deanishe](https://github.com/deanishe) **Base:** `master` ← **Head:** `fix/autofill` --- ### 📝 Commits (1) - [`a5cb2c6`](https://github.com/go-shiori/shiori/commit/a5cb2c6e40063277c0b5eb9ee8a92ddfd044b069) Fix login autofill ### 📊 Changes **2 files changed** (+88 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/login.html` (+26 -20) 📝 `internal/webserver/assets-prod.go` (+62 -62) </details> ### 📄 Description Add `<form>` element, as some browsers won't autofill fields not contained in a form. Fixes #222 Remove username and password bindings, and explicitly read `input`s on login instead. Some browsers do not fire onChange events when a field is autofilled for security reasons, so Vue bindings don't register the change. [More info](https://github.com/facebook/react/issues/1159#issuecomment-506584346). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>