[GH-ISSUE #543] Properly integrate a logging solution #303

New issue

Open

opened 2026-02-25 23:33:54 +03:00 by kerem · 2 comments

kerem commented

2026-02-25 23:33:54 +03:00

Owner

Originally created by @6UzoTE on GitHub (Dec 5, 2022).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/543

Starting shiori like
shiori serve -a 127.0.0.1 --log true
i can specify what is logged but not which level (info,warn,debug....)
It would be nice to reduce the loglevel to eg. warn by having a possibility like
shiori serve -a 127.0.0.1 --log true --loglevel warn

Originally created by @6UzoTE on GitHub (Dec 5, 2022). Original GitHub issue: https://github.com/go-shiori/shiori/issues/543 Starting shiori like `shiori serve -a 127.0.0.1 --log true ` i can specify what is logged but not which level (info,warn,debug....) It would be nice to reduce the loglevel to eg. warn by having a possibility like `shiori serve -a 127.0.0.1 --log true --loglevel warn`

kerem added the

type:enhancement

label

2026-02-25 23:33:54 +03:00

kerem commented

2026-02-25 23:33:54 +03:00

Author

Owner

@stale[bot] commented on GitHub (Jan 4, 2023):

This issue has been automatically marked as stale because it has not had any activity for quite some time.
It will be closed if no further activity occurs.
Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 4, 2023): This issue has been automatically marked as stale because it has not had any activity for quite some time. It will be closed if no further activity occurs. Thank you for your contributions.

kerem commented

2026-02-25 23:33:54 +03:00

Author

Owner

@fmartingr commented on GitHub (Jan 21, 2023):

Hey @6UzoTE, I've renamed your request since there's more to be done. currently we have a tiny logrus implementation in place for the access log, which is the thing you enable with the --log flag in the serve command, but is not propagated anywhere else. For this to work as I intend we need to integrate/setup a logging solution and then propagate it across the code so the output is unified and makes sense. I'm still not 100% sold on logrus at the moment, but we'll see.

Of course, when this happens, a log-level flag will be added so the users can set the log level they prefer.

@fmartingr commented on GitHub (Jan 21, 2023): Hey @6UzoTE, I've renamed your request since there's more to be done. currently we have a tiny logrus implementation in place for the access log, which is the thing you enable with the `--log` flag in the `serve` command, but is not propagated anywhere else. For this to work as I intend we need to integrate/setup a logging solution and then propagate it across the code so the output is unified and makes sense. I'm still not 100% sold on logrus at the moment, but we'll see. Of course, when this happens, a `log-level` flag will be added so the users can set the log level they prefer.