[PR #3540] [MERGED] Core: Remove checks for symbol version_major and version_minor #3555

New issue

Closed

opened 2026-02-27 22:04:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3540
Author: @StevenMiller123
Created: 9/6/2025
Status: ✅ Merged
Merged: 9/9/2025
Merged by: @squidbus

Base: main ← Head: remove-lib-version-checks

📝 Commits (6)

3de310b Remove checks for module version_major and version_minor
028c56a Clang
0798aa8 Merge remote-tracking branch 'upstream/main' into remove-lib-version-checks
6359c3d Fix rebase
9cf3805 Disable libSceSsl HLE
ad9ee93 Merge remote-tracking branch 'upstream/main' into remove-lib-version-checks

📊 Changes

96 files changed (+4215 additions, -5001 deletions)

View changed files

📝 src/core/libraries/ajm/ajm.cpp (+22 -22)
📝 src/core/libraries/app_content/app_content.cpp (+38 -38)
📝 src/core/libraries/audio/audioin.cpp (+42 -53)
📝 src/core/libraries/audio/audioout.cpp (+71 -94)
📝 src/core/libraries/audio3d/audio3d.cpp (+37 -48)
📝 src/core/libraries/avplayer/avplayer.cpp (+27 -40)
📝 src/core/libraries/camera/camera.cpp (+76 -94)
📝 src/core/libraries/companion/companion_httpd.cpp (+17 -17)
📝 src/core/libraries/companion/companion_util.cpp (+5 -5)
📝 src/core/libraries/disc_map/disc_map.cpp (+5 -7)
📝 src/core/libraries/fiber/fiber.cpp (+15 -17)
📝 src/core/libraries/game_live_streaming/gamelivestreaming.cpp (+51 -51)
📝 src/core/libraries/gnmdriver/gnmdriver.cpp (+254 -365)
📝 src/core/libraries/hmd/hmd.cpp (+137 -169)
📝 src/core/libraries/hmd/hmd_distortion.cpp (+16 -20)
📝 src/core/libraries/hmd/hmd_reprojection.cpp (+35 -54)
📝 src/core/libraries/hmd/hmd_setup_dialog.cpp (+7 -7)
📝 src/core/libraries/ime/error_dialog.cpp (+8 -10)
📝 src/core/libraries/ime/ime.cpp (+54 -55)
📝 src/core/libraries/ime/ime_dialog.cpp (+15 -22)

...and 76 more files

📄 Description

On top of the added complexity of needing to specify these numbers every time we generated a library, we've also run into multiple cases where homebrew that work on real hardware won't work on here because their imports use different versions over what actual firmware libraries may specify.

This PR fixes problems like this by removing the checks entirely, and removing the versions from the LIB_FUNCTION and LIB_OBJ macros. I've also removed the duplicate exports in libSceVrTracker and libSceVideoOut, since those won't be necessary if this is merged.

Based on my local tests, this shouldn't cause any regressions, and should fix the issue with libScePigletv2VSH.sprx that @kalaposfos13 ran into on the Discord server.

This will likely cause merge conflicts with #3476, #3290, #3259, #3231, and #2761

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3540 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 9/6/2025 **Status:** ✅ Merged **Merged:** 9/9/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `remove-lib-version-checks` --- ### 📝 Commits (6) - [`3de310b`](https://github.com/shadps4-emu/shadPS4/commit/3de310beed9be8fc0948599b25ccde25f101e30b) Remove checks for module version_major and version_minor - [`028c56a`](https://github.com/shadps4-emu/shadPS4/commit/028c56aac7eb4a05dd9a72de4cf1d48297e8aea0) Clang - [`0798aa8`](https://github.com/shadps4-emu/shadPS4/commit/0798aa8a2ef3d48660209fd685af28c673532f3a) Merge remote-tracking branch 'upstream/main' into remove-lib-version-checks - [`6359c3d`](https://github.com/shadps4-emu/shadPS4/commit/6359c3daa2a109b220086df11d20396351d10d1a) Fix rebase - [`9cf3805`](https://github.com/shadps4-emu/shadPS4/commit/9cf3805275bb0f4e7e8c429580bd2457c39e9276) Disable libSceSsl HLE - [`ad9ee93`](https://github.com/shadps4-emu/shadPS4/commit/ad9ee93765c90193af4d47b499d10e530516f394) Merge remote-tracking branch 'upstream/main' into remove-lib-version-checks ### 📊 Changes **96 files changed** (+4215 additions, -5001 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/ajm/ajm.cpp` (+22 -22) 📝 `src/core/libraries/app_content/app_content.cpp` (+38 -38) 📝 `src/core/libraries/audio/audioin.cpp` (+42 -53) 📝 `src/core/libraries/audio/audioout.cpp` (+71 -94) 📝 `src/core/libraries/audio3d/audio3d.cpp` (+37 -48) 📝 `src/core/libraries/avplayer/avplayer.cpp` (+27 -40) 📝 `src/core/libraries/camera/camera.cpp` (+76 -94) 📝 `src/core/libraries/companion/companion_httpd.cpp` (+17 -17) 📝 `src/core/libraries/companion/companion_util.cpp` (+5 -5) 📝 `src/core/libraries/disc_map/disc_map.cpp` (+5 -7) 📝 `src/core/libraries/fiber/fiber.cpp` (+15 -17) 📝 `src/core/libraries/game_live_streaming/gamelivestreaming.cpp` (+51 -51) 📝 `src/core/libraries/gnmdriver/gnmdriver.cpp` (+254 -365) 📝 `src/core/libraries/hmd/hmd.cpp` (+137 -169) 📝 `src/core/libraries/hmd/hmd_distortion.cpp` (+16 -20) 📝 `src/core/libraries/hmd/hmd_reprojection.cpp` (+35 -54) 📝 `src/core/libraries/hmd/hmd_setup_dialog.cpp` (+7 -7) 📝 `src/core/libraries/ime/error_dialog.cpp` (+8 -10) 📝 `src/core/libraries/ime/ime.cpp` (+54 -55) 📝 `src/core/libraries/ime/ime_dialog.cpp` (+15 -22) _...and 76 more files_ </details> ### 📄 Description On top of the added complexity of needing to specify these numbers every time we generated a library, we've also run into multiple cases where homebrew that work on real hardware won't work on here because their imports use different versions over what actual firmware libraries may specify. This PR fixes problems like this by removing the checks entirely, and removing the versions from the LIB_FUNCTION and LIB_OBJ macros. I've also removed the duplicate exports in libSceVrTracker and libSceVideoOut, since those won't be necessary if this is merged. Based on my local tests, this shouldn't cause any regressions, and should fix the issue with libScePigletv2VSH.sprx that @kalaposfos13 ran into on the Discord server. This will likely cause merge conflicts with #3476, #3290, #3259, #3231, and #2761 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>