[PR #3109] [MERGED] KBM Input Bug Fixes / Added Binds v2 #3231

New issue

Closed

opened 2026-02-27 22:02:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3109
Author: @nickci2002
Created: 6/17/2025
Status: ✅ Merged
Merged: 6/20/2025
Merged by: @kalaposfos13

Base: main ← Head: input-fix-real

📝 Commits (10+)

dffd477 fixed nonload issues with background music (#3094)
ed78407 Merge branch 'shadps4-emu:main' into input-fix-real
eb75efc Fixing my pull request branch
38f2cdd Pull request change part 2
9534458 Continued changes to project and altered kbm_help_dialog.h text to QStringLiterals
d9dbee3 Finalized commit and changed kbm_help_dialog.h
d5d6a76 KBM Input Bug Fixes / Added Binds
135bc0c Merge remote-tracking branch 'origin/input-fix-real' into input-fix-real
429c64a Updated C-style casts in kbm_gui.cpp
990e349 Fixed formatting from clang-format

📊 Changes

6 files changed (+568 additions, -613 deletions)

View changed files

📝 src/input/input_handler.cpp (+17 -14)
📝 src/input/input_handler.h (+83 -48)
📝 src/qt_gui/kbm_gui.cpp (+290 -393)
📝 src/qt_gui/kbm_gui.h (+12 -16)
📝 src/qt_gui/kbm_help_dialog.cpp (+161 -4)
📝 src/qt_gui/kbm_help_dialog.h (+5 -138)

📄 Description

Fixed input issues where some inputs would not bind when pressing (side mouse buttons, some symbols, etc). Also, fixed up code formatting in altered files (removed C-style casts and replaced with C++ <static_casts>, added a few macros and one member functions).
This is v2 of my commit, addressing all issues brought up by @kalaposfos13

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3109 **Author:** [@nickci2002](https://github.com/nickci2002) **Created:** 6/17/2025 **Status:** ✅ Merged **Merged:** 6/20/2025 **Merged by:** [@kalaposfos13](https://github.com/kalaposfos13) **Base:** `main` ← **Head:** `input-fix-real` --- ### 📝 Commits (10+) - [`dffd477`](https://github.com/shadps4-emu/shadPS4/commit/dffd477fa8dc3b3bc1ca7d2018914322e922de1b) fixed nonload issues with background music (#3094) - [`ed78407`](https://github.com/shadps4-emu/shadPS4/commit/ed784071276fe75a036120780ff51eb0448fa092) Merge branch 'shadps4-emu:main' into input-fix-real - [`eb75efc`](https://github.com/shadps4-emu/shadPS4/commit/eb75efc90389a24734b9c7e5ca81562571904c28) Fixing my pull request branch - [`38f2cdd`](https://github.com/shadps4-emu/shadPS4/commit/38f2cdd630a2c215f6141f38e09beffc1d7e768a) Pull request change part 2 - [`9534458`](https://github.com/shadps4-emu/shadPS4/commit/9534458a610426619ccab538370dfb0bf7d89790) Continued changes to project and altered kbm_help_dialog.h text to QStringLiterals - [`d9dbee3`](https://github.com/shadps4-emu/shadPS4/commit/d9dbee355d262e876e01dec53fe650d5995a36e8) Finalized commit and changed kbm_help_dialog.h - [`d5d6a76`](https://github.com/shadps4-emu/shadPS4/commit/d5d6a760f271a6af9599cc7754bc307718b3f05a) KBM Input Bug Fixes / Added Binds - [`135bc0c`](https://github.com/shadps4-emu/shadPS4/commit/135bc0c020d3ea4183abd70e797d76e5ab0a8800) Merge remote-tracking branch 'origin/input-fix-real' into input-fix-real - [`429c64a`](https://github.com/shadps4-emu/shadPS4/commit/429c64a51baad3cc56bc6537be672ac3754603ae) Updated C-style casts in kbm_gui.cpp - [`990e349`](https://github.com/shadps4-emu/shadPS4/commit/990e349424aed9983e25b63d759c95d1719a1a5f) Fixed formatting from clang-format ### 📊 Changes **6 files changed** (+568 additions, -613 deletions) <details> <summary>View changed files</summary> 📝 `src/input/input_handler.cpp` (+17 -14) 📝 `src/input/input_handler.h` (+83 -48) 📝 `src/qt_gui/kbm_gui.cpp` (+290 -393) 📝 `src/qt_gui/kbm_gui.h` (+12 -16) 📝 `src/qt_gui/kbm_help_dialog.cpp` (+161 -4) 📝 `src/qt_gui/kbm_help_dialog.h` (+5 -138) </details> ### 📄 Description Fixed input issues where some inputs would not bind when pressing (side mouse buttons, some symbols, etc). Also, fixed up code formatting in altered files (removed C-style casts and replaced with C++ <static_casts>, added a few macros and one member functions). This is v2 of my commit, addressing all issues brought up by @kalaposfos13 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>