[PR #2473] [CLOSED] fix: remove incorrect use of std namespace #2761

Closed
opened 2026-02-27 22:01:09 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2473
Author: @jardon
Created: 2/18/2025
Status: Closed

Base: mainHead: fix/std-namespace-err


📝 Commits (1)

  • 61d4607 fix: remove incorrect use of std namespace

📊 Changes

4 files changed (+37 additions, -37 deletions)

View changed files

📝 src/core/devices/random_device.cpp (+1 -1)
📝 src/core/devices/srandom_device.cpp (+1 -1)
📝 src/core/devices/urandom_device.cpp (+1 -1)
📝 src/core/libraries/libc_internal/libc_internal_math.cpp (+34 -34)

📄 Description

  • remove std namespace from random time refs
  • remove std namespace from libc internal math

this may not be needed or could be implemented differently, but these were issues i hit building

/var/home/jardon/Projects/shadPS4/src/core/libraries/libc_internal/libc_internal_math.cpp:491:13: error: no member named 'cosf' in namespace 'std'; did you mean simply 'cosf'?
  491 |     *cosp = std::cosf(x);
      |             ^~~~~~~~~
      |             cosf

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2473 **Author:** [@jardon](https://github.com/jardon) **Created:** 2/18/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/std-namespace-err` --- ### 📝 Commits (1) - [`61d4607`](https://github.com/shadps4-emu/shadPS4/commit/61d46073da7e335b815abf2a89e2c3dc7a97b3ca) fix: remove incorrect use of std namespace ### 📊 Changes **4 files changed** (+37 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/core/devices/random_device.cpp` (+1 -1) 📝 `src/core/devices/srandom_device.cpp` (+1 -1) 📝 `src/core/devices/urandom_device.cpp` (+1 -1) 📝 `src/core/libraries/libc_internal/libc_internal_math.cpp` (+34 -34) </details> ### 📄 Description - remove std namespace from random time refs - remove std namespace from libc internal math this may not be needed or could be implemented differently, but these were issues i hit building ``` /var/home/jardon/Projects/shadPS4/src/core/libraries/libc_internal/libc_internal_math.cpp:491:13: error: no member named 'cosf' in namespace 'std'; did you mean simply 'cosf'? 491 | *cosp = std::cosf(x); | ^~~~~~~~~ | cosf ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:01:09 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2761
No description provided.