mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #1310] add logging hint to check the source sample rate on buffer underruns #595
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#595
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bitclick on GitHub (Aug 7, 2024).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/1310
Is your feature request related to a problem? Please describe.
i was having drop outs regularly and thought - oh my wifi sucks..
but it turns out i had setup librespot via pipe source and never set the sample rate to 44.1khz so i was getting
a lot of
next read < 0log outputi suffered from this more than 12 months 😅
i did not think further because the log never mentioned "drop out" or "warning" or something like this
Describe the solution you'd like
please ad a hint to the log output when buffer underruns occur like
"looks like the source is too slow, i am expecting xxx sample format. is this correct?"
and maybe a link to this issue or some doc page https://github.com/librespot-org/librespot/issues/340
Describe alternatives you've considered
i think the problem is that it kinda works with mismatched sample rates so its not that obvious for the user to check the config. i always thought the clients had buffer underruns and tweaked my wifi. if the logs could make the distinction more explicit, this would help a lot of people..
@kingosticks commented on GitHub (Aug 7, 2024):
This makes no sense. Are you talking about librespot or something using librespot?
Either way, as I said in the issue you linked:
How could librespot know that the consuming side of the pipe is underruning?
@bitclick commented on GitHub (Aug 7, 2024):
ah sorry wrong project 😅 got my tabs confused. ment to post this here https://github.com/badaix/snapcast
will close this.
@bitclick commented on GitHub (Aug 7, 2024):
not relevant for this project