[PR #1271] [MERGED] Tweak/devcontainer #1310

New issue

Closed

opened 2026-02-27 20:01:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1271
Author: @yubiuser
Created: 3/31/2024
Status: ✅ Merged
Merged: 5/11/2024
Merged by: @roderickvd

Base: dev ← Head: tweak/devcontainer

📝 Commits (3)

a692b8c Bump rust version to 1.71 on devcontainer
b24fb87 Add test.sh to allow to run test suite easily
7bc7b46 Don't remove dev dependencies but instead use --no-dev-deps option of cargo hack which will restore Cargo.toml after run

📊 Changes

2 files changed (+22 additions, -1 deletions)

View changed files

📝 .devcontainer/Dockerfile (+1 -1)
➕ test.sh (+21 -0)

📄 Description

Updates the rust version used in the devcontainer to 1.71 (wich matches the current) MSRV.
Adds test.sh which will run all test that run as part of the test.yml from the github action locally. This eases development as one can check for failures locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1271 **Author:** [@yubiuser](https://github.com/yubiuser) **Created:** 3/31/2024 **Status:** ✅ Merged **Merged:** 5/11/2024 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `tweak/devcontainer` --- ### 📝 Commits (3) - [`a692b8c`](https://github.com/librespot-org/librespot/commit/a692b8cccc464136ded44a5a9dff130cc05254f0) Bump rust version to 1.71 on devcontainer - [`b24fb87`](https://github.com/librespot-org/librespot/commit/b24fb871aeff0925a2c912027798a6d6bdf47ac9) Add test.sh to allow to run test suite easily - [`7bc7b46`](https://github.com/librespot-org/librespot/commit/7bc7b46b9e02cb738446b071f490a118832ab02f) Don't remove dev dependencies but instead use --no-dev-deps option of cargo hack which will restore Cargo.toml after run ### 📊 Changes **2 files changed** (+22 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+1 -1) ➕ `test.sh` (+21 -0) </details> ### 📄 Description - Updates the rust version used in the devcontainer to 1.71 (wich matches the current) MSRV. - Adds `test.sh` which will run all test that run as part of the `test.yml` from the github action locally. This eases development as one can check for failures locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:58 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1310

No description provided.

Rows
Columns