[PR #683] [CLOSED] Merge dev into tokio_migration and fix warnings #1016

New issue

Closed

opened 2026-02-27 20:00:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/683
Author: @Johannesd3
Created: 3/31/2021
Status: ❌ Closed

Base: tokio_migration ← Head: tokio_migration

📝 Commits (10+)

09e506e Replace version functions by constants
85be0d0 Adjust documentation
bce4858 Add semver constant, rename "build id" env var
c8e45ab Modified startup message
58bd339 Restore MSRV to 1.41
da0e913 Merge pull request #647 from Johannesd3/msrv_1.41
4beb3d5 Add version string CLI parameter, set name to optional parameter, default to 'librespot'
56f1fb6 Merge pull request #595 from Johannesd3/const_versions
8dc1e80 separated stream for each seek
86dbaa8 true/false don't need to be explicit

📊 Changes

21 files changed (+201 additions, -195 deletions)

View changed files

📝 .github/workflows/test.yml (+1 -1)
📝 COMPILING.md (+1 -1)
📝 Cargo.lock (+4 -4)
📝 audio/src/passthrough_decoder.rs (+92 -79)
📝 connect/src/spirc.rs (+1 -1)
📝 core/build.rs (+2 -1)
📝 core/src/apresolve.rs (+2 -2)
📝 core/src/authentication.rs (+2 -5)
📝 core/src/config.rs (+10 -10)
📝 core/src/connection/codec.rs (+6 -6)
📝 core/src/connection/handshake.rs (+5 -5)
📝 core/src/connection/mod.rs (+5 -5)
📝 core/src/diffie_hellman.rs (+4 -4)
📝 core/src/mercury/mod.rs (+3 -3)
📝 core/src/mercury/types.rs (+11 -11)
📝 core/src/spotify_id.rs (+3 -3)
📝 core/src/version.rs (+12 -39)
📝 examples/get_token.rs (+3 -1)
📝 examples/play.rs (+5 -5)
📝 examples/playlist_tracks.rs (+3 -1)

...and 1 more files

📄 Description

... and fix (new?) clippy lints. Clippy didn't like the naming of some types and enum variants, consecutive upper letters are probably reserved for constants.

Maybe it's possible to fast-forward this merge to avoid an additional (useless) merge commit, but I'm no github pr expert.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/683 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 3/31/2021 **Status:** ❌ Closed **Base:** `tokio_migration` ← **Head:** `tokio_migration` --- ### 📝 Commits (10+) - [`09e506e`](https://github.com/librespot-org/librespot/commit/09e506ed668c582f4a9c6af928465d222c967392) Replace version functions by constants - [`85be0d0`](https://github.com/librespot-org/librespot/commit/85be0d075a93d167476b355c4a93602c808ba689) Adjust documentation - [`bce4858`](https://github.com/librespot-org/librespot/commit/bce4858b9e0bd5308376dcba90c17f14c74a969c) Add semver constant, rename "build id" env var - [`c8e45ab`](https://github.com/librespot-org/librespot/commit/c8e45ab6903d299d46acaee71d91ceec63a09457) Modified startup message - [`58bd339`](https://github.com/librespot-org/librespot/commit/58bd339e90ddf6f8a53dd23f8deb00392b9868af) Restore MSRV to 1.41 - [`da0e913`](https://github.com/librespot-org/librespot/commit/da0e913fa549a1b0577b97faa2b51d7338cd59fa) Merge pull request #647 from Johannesd3/msrv_1.41 - [`4beb3d5`](https://github.com/librespot-org/librespot/commit/4beb3d5e60dd4992691a6ac896aab4911a86cd2b) Add version string CLI parameter, set name to optional parameter, default to 'librespot' - [`56f1fb6`](https://github.com/librespot-org/librespot/commit/56f1fb6dae081daa88b4429c3970174ea45a0c91) Merge pull request #595 from Johannesd3/const_versions - [`8dc1e80`](https://github.com/librespot-org/librespot/commit/8dc1e80633cccebed2a28224d8e43b19047d747e) separated stream for each seek - [`86dbaa8`](https://github.com/librespot-org/librespot/commit/86dbaa8ed53c5b76414d1a577f680d2a65dd2c89) true/false don't need to be explicit ### 📊 Changes **21 files changed** (+201 additions, -195 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+1 -1) 📝 `COMPILING.md` (+1 -1) 📝 `Cargo.lock` (+4 -4) 📝 `audio/src/passthrough_decoder.rs` (+92 -79) 📝 `connect/src/spirc.rs` (+1 -1) 📝 `core/build.rs` (+2 -1) 📝 `core/src/apresolve.rs` (+2 -2) 📝 `core/src/authentication.rs` (+2 -5) 📝 `core/src/config.rs` (+10 -10) 📝 `core/src/connection/codec.rs` (+6 -6) 📝 `core/src/connection/handshake.rs` (+5 -5) 📝 `core/src/connection/mod.rs` (+5 -5) 📝 `core/src/diffie_hellman.rs` (+4 -4) 📝 `core/src/mercury/mod.rs` (+3 -3) 📝 `core/src/mercury/types.rs` (+11 -11) 📝 `core/src/spotify_id.rs` (+3 -3) 📝 `core/src/version.rs` (+12 -39) 📝 `examples/get_token.rs` (+3 -1) 📝 `examples/play.rs` (+5 -5) 📝 `examples/playlist_tracks.rs` (+3 -1) _...and 1 more files_ </details> ### 📄 Description ... and fix (new?) clippy lints. Clippy didn't like the naming of some types and enum variants, consecutive upper letters are probably reserved for constants. Maybe it's possible to fast-forward this merge to avoid an additional (useless) merge commit, but I'm no github pr expert. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:50 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1016

No description provided.

Rows
Columns