[PR #687] [MERGED] Further progress on tokio migration #1021

New issue

Closed

opened 2026-02-27 20:00:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/687
Author: @Johannesd3
Created: 4/9/2021
Status: ✅ Merged
Merged: 4/11/2021
Merged by: @sashahilton00

Base: tokio_migration ← Head: tokio_migration

📝 Commits (10+)

09e506e Replace version functions by constants
85be0d0 Adjust documentation
bce4858 Add semver constant, rename "build id" env var
c8e45ab Modified startup message
58bd339 Restore MSRV to 1.41
da0e913 Merge pull request #647 from Johannesd3/msrv_1.41
4beb3d5 Add version string CLI parameter, set name to optional parameter, default to 'librespot'
56f1fb6 Merge pull request #595 from Johannesd3/const_versions
8dc1e80 separated stream for each seek
f29e521 High-resolution volume control and normalisation

📊 Changes

49 files changed (+1405 additions, -1221 deletions)

View changed files

📝 .github/workflows/test.yml (+105 -34)
📝 COMPILING.md (+1 -1)
📝 Cargo.lock (+64 -534)
📝 Cargo.toml (+3 -5)
📝 audio/Cargo.toml (+5 -5)
➕ audio/src/convert.rs (+56 -0)
📝 audio/src/lewton_decoder.rs (+5 -2)
📝 audio/src/lib.rs (+6 -14)
📝 audio/src/libvorbis_decoder.rs (+12 -1)
📝 audio/src/passthrough_decoder.rs (+92 -79)
📝 connect/Cargo.toml (+2 -4)
📝 connect/src/discovery.rs (+9 -18)
📝 connect/src/spirc.rs (+6 -3)
📝 core/Cargo.toml (+2 -1)
📝 core/build.rs (+2 -1)
📝 core/src/apresolve.rs (+25 -2)
📝 core/src/authentication.rs (+2 -5)
📝 core/src/config.rs (+10 -10)
📝 core/src/connection/codec.rs (+6 -6)
📝 core/src/connection/handshake.rs (+10 -8)

...and 29 more files

📄 Description

This bundles #668 and #683 into one PR (I'm sick of multiple parallel PRs).

Merge the latest dev into tokio_migration
Fix clippy warnings and formatting.
Get rid of most of the util module (Formerly #668).
Improve CI (after fixing errors which would prevent it from succeeding). In contrast to the solution presented in #683, the macOS build was removed because of strange errors as result of caching the target directory.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/687 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 4/9/2021 **Status:** ✅ Merged **Merged:** 4/11/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `tokio_migration` ← **Head:** `tokio_migration` --- ### 📝 Commits (10+) - [`09e506e`](https://github.com/librespot-org/librespot/commit/09e506ed668c582f4a9c6af928465d222c967392) Replace version functions by constants - [`85be0d0`](https://github.com/librespot-org/librespot/commit/85be0d075a93d167476b355c4a93602c808ba689) Adjust documentation - [`bce4858`](https://github.com/librespot-org/librespot/commit/bce4858b9e0bd5308376dcba90c17f14c74a969c) Add semver constant, rename "build id" env var - [`c8e45ab`](https://github.com/librespot-org/librespot/commit/c8e45ab6903d299d46acaee71d91ceec63a09457) Modified startup message - [`58bd339`](https://github.com/librespot-org/librespot/commit/58bd339e90ddf6f8a53dd23f8deb00392b9868af) Restore MSRV to 1.41 - [`da0e913`](https://github.com/librespot-org/librespot/commit/da0e913fa549a1b0577b97faa2b51d7338cd59fa) Merge pull request #647 from Johannesd3/msrv_1.41 - [`4beb3d5`](https://github.com/librespot-org/librespot/commit/4beb3d5e60dd4992691a6ac896aab4911a86cd2b) Add version string CLI parameter, set name to optional parameter, default to 'librespot' - [`56f1fb6`](https://github.com/librespot-org/librespot/commit/56f1fb6dae081daa88b4429c3970174ea45a0c91) Merge pull request #595 from Johannesd3/const_versions - [`8dc1e80`](https://github.com/librespot-org/librespot/commit/8dc1e80633cccebed2a28224d8e43b19047d747e) separated stream for each seek - [`f29e521`](https://github.com/librespot-org/librespot/commit/f29e5212c402074c1a12eb493af7e5d4c966dcdf) High-resolution volume control and normalisation ### 📊 Changes **49 files changed** (+1405 additions, -1221 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+105 -34) 📝 `COMPILING.md` (+1 -1) 📝 `Cargo.lock` (+64 -534) 📝 `Cargo.toml` (+3 -5) 📝 `audio/Cargo.toml` (+5 -5) ➕ `audio/src/convert.rs` (+56 -0) 📝 `audio/src/lewton_decoder.rs` (+5 -2) 📝 `audio/src/lib.rs` (+6 -14) 📝 `audio/src/libvorbis_decoder.rs` (+12 -1) 📝 `audio/src/passthrough_decoder.rs` (+92 -79) 📝 `connect/Cargo.toml` (+2 -4) 📝 `connect/src/discovery.rs` (+9 -18) 📝 `connect/src/spirc.rs` (+6 -3) 📝 `core/Cargo.toml` (+2 -1) 📝 `core/build.rs` (+2 -1) 📝 `core/src/apresolve.rs` (+25 -2) 📝 `core/src/authentication.rs` (+2 -5) 📝 `core/src/config.rs` (+10 -10) 📝 `core/src/connection/codec.rs` (+6 -6) 📝 `core/src/connection/handshake.rs` (+10 -8) _...and 29 more files_ </details> ### 📄 Description This bundles #668 and #683 into one PR (I'm sick of multiple parallel PRs). * Merge the latest `dev` into `tokio_migration` * Fix clippy warnings and formatting. * Get rid of most of the `util` module (Formerly #668). * Improve CI (after fixing errors which would prevent it from succeeding). In contrast to the solution presented in #683, the macOS build was removed because of strange errors as result of caching the target directory. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:51 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:32 +03:00

[PR #1021] [CLOSED] Bump vergen version #1198

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1021

No description provided.

Rows
Columns