[PR #2670] [MERGED] Clean up DNSSEC support #3221

New issue

Closed

opened 2026-03-16 11:31:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:31:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2670
Author: @djc
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/19/2024
Merged by: @djc

Base: main ← Head: aws-lc-rs

📝 Commits (10+)

5e90fa9 proto: remove unused openssl module
1331034 Remove support for reading encrypted private keys
a72ea67 Remove nested compilation guards
fef8834 Remove intermediate layer of dnssec features
e6fb00e proto: move digest logic into ring module
1b02664 proto: replace DigestType::from_u8() with TryFrom impl
f50f24c proto: remove TryFrom impl for DigestType
d0a482c proto: move DigestType into dnssec root module
019c4c7 Stop passing key algorithms in parallel
f319b11 Expose SigningKey algorithm

📊 Changes

83 files changed (+1207 additions, -1854 deletions)

View changed files

📝 Cargo.lock (+4 -0)
📝 Cargo.toml (+1 -0)
📝 bin/Cargo.toml (+3 -3)
📝 bin/src/dnssec.rs (+139 -204)
📝 bin/src/hickory-dns.rs (+15 -271)
📝 bin/src/lib.rs (+274 -19)
📝 bin/tests/integration/authority_battery/dnssec.rs (+1 -3)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+13 -15)
📝 bin/tests/integration/config_tests.rs (+59 -50)
📝 bin/tests/integration/in_memory.rs (+2 -2)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+8 -27)
📝 bin/tests/integration/server_harness/mod.rs (+6 -6)
📝 bin/tests/integration/server_harness/mut_message_client.rs (+5 -5)
📝 bin/tests/integration/store_file_tests.rs (+6 -6)
📝 bin/tests/integration/store_sqlite_tests.rs (+5 -5)
📝 bin/tests/integration/txt_tests.rs (+5 -5)
➕ bin/tests/test-data/rsa-2048-pkcs1.pem (+27 -0)
➕ bin/tests/test-data/rsa-2048-pkcs1.pem.pub (+1 -0)
➕ bin/tests/test-data/rsa-2048-pkcs8.pem (+28 -0)
📝 crates/client/Cargo.toml (+1 -2)

...and 63 more files

📄 Description

Clean up DNSSEC code to improve boundaries between DNSSEC/no DNSSEC and specific crypto backends.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2670 **Author:** [@djc](https://github.com/djc) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/19/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `aws-lc-rs` --- ### 📝 Commits (10+) - [`5e90fa9`](https://github.com/hickory-dns/hickory-dns/commit/5e90fa942c2d56c4b82a3ce4e883acc64f2e11da) proto: remove unused openssl module - [`1331034`](https://github.com/hickory-dns/hickory-dns/commit/1331034d35ab7cbf0ae3c1b81233e901f99a9169) Remove support for reading encrypted private keys - [`a72ea67`](https://github.com/hickory-dns/hickory-dns/commit/a72ea6796a3e282e3db0411a0a14d1d675b0a934) Remove nested compilation guards - [`fef8834`](https://github.com/hickory-dns/hickory-dns/commit/fef88345f64c61e89a98f089b9183afa08415d9a) Remove intermediate layer of dnssec features - [`e6fb00e`](https://github.com/hickory-dns/hickory-dns/commit/e6fb00e09509474ab55d13ce6b95bede25266bd9) proto: move digest logic into ring module - [`1b02664`](https://github.com/hickory-dns/hickory-dns/commit/1b026644496e2cc676a271b26888efcf3c65c849) proto: replace DigestType::from_u8() with TryFrom impl - [`f50f24c`](https://github.com/hickory-dns/hickory-dns/commit/f50f24c2ff06ccdda3d20ddb3eb36eedf2674bee) proto: remove TryFrom<Algorithm> impl for DigestType - [`d0a482c`](https://github.com/hickory-dns/hickory-dns/commit/d0a482ce0f2308a71f2ed0666d13c7468dc1c40c) proto: move DigestType into dnssec root module - [`019c4c7`](https://github.com/hickory-dns/hickory-dns/commit/019c4c7e41c08768973b9fd17f5f1279fc0e804d) Stop passing key algorithms in parallel - [`f319b11`](https://github.com/hickory-dns/hickory-dns/commit/f319b11ff12045c0646d38dcc9bb394ebec1a4d8) Expose SigningKey algorithm ### 📊 Changes **83 files changed** (+1207 additions, -1854 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+4 -0) 📝 `Cargo.toml` (+1 -0) 📝 `bin/Cargo.toml` (+3 -3) 📝 `bin/src/dnssec.rs` (+139 -204) 📝 `bin/src/hickory-dns.rs` (+15 -271) 📝 `bin/src/lib.rs` (+274 -19) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+1 -3) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+13 -15) 📝 `bin/tests/integration/config_tests.rs` (+59 -50) 📝 `bin/tests/integration/in_memory.rs` (+2 -2) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+8 -27) 📝 `bin/tests/integration/server_harness/mod.rs` (+6 -6) 📝 `bin/tests/integration/server_harness/mut_message_client.rs` (+5 -5) 📝 `bin/tests/integration/store_file_tests.rs` (+6 -6) 📝 `bin/tests/integration/store_sqlite_tests.rs` (+5 -5) 📝 `bin/tests/integration/txt_tests.rs` (+5 -5) ➕ `bin/tests/test-data/rsa-2048-pkcs1.pem` (+27 -0) ➕ `bin/tests/test-data/rsa-2048-pkcs1.pem.pub` (+1 -0) ➕ `bin/tests/test-data/rsa-2048-pkcs8.pem` (+28 -0) 📝 `crates/client/Cargo.toml` (+1 -2) _...and 63 more files_ </details> ### 📄 Description Clean up DNSSEC code to improve boundaries between DNSSEC/no DNSSEC and specific crypto backends. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>