[PR #3243] [MERGED] proto: move message types around #3673

New issue

Closed

opened 2026-03-16 11:56:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:56:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3243
Author: @djc
Created: 8/31/2025
Status: ✅ Merged
Merged: 9/2/2025
Merged by: @djc

Base: main ← Head: message-types

📝 Commits (8)

4d6ab98 proto: move DnsResponseStream out of dns_response module
e922ab1 proto: discard unused NegativeType API
169cacf proto: clean up exports in op
e56f9fa proto: privatize structure inside op
a0636e5 proto: move dns_request from xfer to op
98a2ea3 proto: move serial_message from xfer to op
f8300b7 proto: move dns_response from xfer to op
5a325e9 proto: privatize test utilities

📊 Changes

70 files changed (+581 additions, -1119 deletions)

View changed files

📝 bin/tests/integration/named_metrics_tests.rs (+2 -2)
📝 bin/tests/integration/server_harness/mod.rs (+2 -2)
📝 bin/tests/integration/server_harness/mut_message_client.rs (+2 -1)
📝 crates/client/src/client/client.rs (+5 -2)
📝 crates/client/src/client/dnssec_client.rs (+2 -3)
📝 crates/client/src/client/memoize_client_handle.rs (+6 -6)
📝 crates/client/src/tests.rs (+1 -1)
📝 crates/proto/src/dnssec/handle.rs (+2 -2)
📝 crates/proto/src/dnssec/tsig.rs (+3 -3)
📝 crates/proto/src/error.rs (+1 -2)
📝 crates/proto/src/h2/h2_client_stream.rs (+5 -5)
📝 crates/proto/src/h3/h3_client_stream.rs (+5 -5)
📝 crates/proto/src/lib.rs (+0 -2)
📝 crates/proto/src/multicast/mdns_client_stream.rs (+2 -1)
📝 crates/proto/src/multicast/mdns_stream.rs (+1 -1)
📝 crates/proto/src/op/dns_request.rs (+0 -0)
➕ crates/proto/src/op/dns_response.rs (+282 -0)
📝 crates/proto/src/op/message.rs (+5 -6)
📝 crates/proto/src/op/mod.rs (+31 -14)
📝 crates/proto/src/op/op_code.rs (+2 -2)

...and 50 more files

📄 Description

Initial steps toward

#3221

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3243 **Author:** [@djc](https://github.com/djc) **Created:** 8/31/2025 **Status:** ✅ Merged **Merged:** 9/2/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `message-types` --- ### 📝 Commits (8) - [`4d6ab98`](https://github.com/hickory-dns/hickory-dns/commit/4d6ab9854917c7a56fc673d3afe164c3424ae0d8) proto: move DnsResponseStream out of dns_response module - [`e922ab1`](https://github.com/hickory-dns/hickory-dns/commit/e922ab120db62215c8522faadec6fe721969a5b2) proto: discard unused NegativeType API - [`169cacf`](https://github.com/hickory-dns/hickory-dns/commit/169cacf51822de15db76e5a12cbbd88370444e2f) proto: clean up exports in op - [`e56f9fa`](https://github.com/hickory-dns/hickory-dns/commit/e56f9fa79068f97496f7842c857f9d2ea960548f) proto: privatize structure inside op - [`a0636e5`](https://github.com/hickory-dns/hickory-dns/commit/a0636e5913c6955f0236d627496ac7d1d97f8dc5) proto: move dns_request from xfer to op - [`98a2ea3`](https://github.com/hickory-dns/hickory-dns/commit/98a2ea3de4b3598ea263ba9712a9e08e6712d461) proto: move serial_message from xfer to op - [`f8300b7`](https://github.com/hickory-dns/hickory-dns/commit/f8300b7ad2cb3d63da5894303d797c87b764c199) proto: move dns_response from xfer to op - [`5a325e9`](https://github.com/hickory-dns/hickory-dns/commit/5a325e9b4ca655a1e43493b7792b17f016395068) proto: privatize test utilities ### 📊 Changes **70 files changed** (+581 additions, -1119 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/named_metrics_tests.rs` (+2 -2) 📝 `bin/tests/integration/server_harness/mod.rs` (+2 -2) 📝 `bin/tests/integration/server_harness/mut_message_client.rs` (+2 -1) 📝 `crates/client/src/client/client.rs` (+5 -2) 📝 `crates/client/src/client/dnssec_client.rs` (+2 -3) 📝 `crates/client/src/client/memoize_client_handle.rs` (+6 -6) 📝 `crates/client/src/tests.rs` (+1 -1) 📝 `crates/proto/src/dnssec/handle.rs` (+2 -2) 📝 `crates/proto/src/dnssec/tsig.rs` (+3 -3) 📝 `crates/proto/src/error.rs` (+1 -2) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+5 -5) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+5 -5) 📝 `crates/proto/src/lib.rs` (+0 -2) 📝 `crates/proto/src/multicast/mdns_client_stream.rs` (+2 -1) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+1 -1) 📝 `crates/proto/src/op/dns_request.rs` (+0 -0) ➕ `crates/proto/src/op/dns_response.rs` (+282 -0) 📝 `crates/proto/src/op/message.rs` (+5 -6) 📝 `crates/proto/src/op/mod.rs` (+31 -14) 📝 `crates/proto/src/op/op_code.rs` (+2 -2) _...and 50 more files_ </details> ### 📄 Description Initial steps toward - #3221 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>