[PR #1885] [MERGED] client: rm zone parse optional class arg. #2670

New issue

Closed

opened 2026-03-16 11:01:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:01:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1885
Author: @cpu
Created: 1/17/2023
Status: ✅ Merged
Merged: 1/18/2023
Merged by: @bluejekyll

Base: main ← Head: cpu-zone-parse-no-arg

📝 Commits (1)

20ee4e5 client: rm zone parse optional class arg.

📊 Changes

5 files changed (+15 additions, -53 deletions)

View changed files

📝 crates/client/src/serialize/txt/rdata_parsers/svcb.rs (+1 -2)
📝 crates/client/src/serialize/txt/zone.rs (+6 -42)
📝 crates/server/src/store/file/authority.rs (+1 -2)
📝 crates/server/src/store/recursor/config.rs (+2 -2)
📝 crates/server/tests/txt_tests.rs (+5 -5)

📄 Description

This branch is a follow-up for https://github.com/bluejekyll/trust-dns/pull/1874. It removes the optional DNSClass argument from the client crate's txt serialization Parser.parse func.

For trust-dns's use-cases the argument is redundant and we can assume the IN ("internet") class. Records parsed from the zone data must either omit a class (in which case IN is implicit) or specify IN explicitly (no mismatched classes).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1885 **Author:** [@cpu](https://github.com/cpu) **Created:** 1/17/2023 **Status:** ✅ Merged **Merged:** 1/18/2023 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `cpu-zone-parse-no-arg` --- ### 📝 Commits (1) - [`20ee4e5`](https://github.com/hickory-dns/hickory-dns/commit/20ee4e5bbdf52d18f0ec02d455e29c3d148a68d7) client: rm zone parse optional class arg. ### 📊 Changes **5 files changed** (+15 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/rdata_parsers/svcb.rs` (+1 -2) 📝 `crates/client/src/serialize/txt/zone.rs` (+6 -42) 📝 `crates/server/src/store/file/authority.rs` (+1 -2) 📝 `crates/server/src/store/recursor/config.rs` (+2 -2) 📝 `crates/server/tests/txt_tests.rs` (+5 -5) </details> ### 📄 Description This branch is a follow-up for https://github.com/bluejekyll/trust-dns/pull/1874. It removes the optional DNSClass argument from the client crate's txt serialization `Parser.parse` func. For trust-dns's use-cases the argument is redundant and we can assume the IN ("internet") class. Records parsed from the zone data must either omit a class (in which case IN is implicit) or specify IN explicitly (no mismatched classes). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>