[PR #3366] [MERGED] Fold client crate into proto::client #3780

New issue

Closed

opened 2026-03-16 12:02:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:02:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3366
Author: @djc
Created: 11/27/2025
Status: ✅ Merged
Merged: 11/27/2025
Merged by: @djc

Base: main ← Head: merge-client

📝 Commits (5)

ecefa51 bin: use bin crate version in logging
8706f57 proto: fold client crate into proto::client
1d8ff51 proto: regroup imports in client root
1cb0c71 proto: fold client::client into client
35caf1d proto: collect client tests into separate file

📊 Changes

47 files changed (+474 additions, -1058 deletions)

View changed files

📝 Cargo.lock (+1 -25)
📝 Cargo.toml (+0 -2)
📝 bin/Cargo.toml (+0 -1)
📝 bin/benches/comparison_benches.rs (+1 -1)
📝 bin/src/hickory-dns.rs (+4 -4)
📝 bin/tests/integration/named_https_tests.rs (+1 -1)
📝 bin/tests/integration/named_metrics_tests.rs (+1 -1)
📝 bin/tests/integration/named_quic_tests.rs (+1 -1)
📝 bin/tests/integration/named_rustls_tests.rs (+1 -1)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+2 -2)
📝 bin/tests/integration/named_tests.rs (+1 -1)
📝 bin/tests/integration/server_harness/mod.rs (+2 -2)
📝 bin/tests/integration/server_harness/mut_message_client.rs (+1 -1)
📝 conformance/Cargo.lock (+0 -17)
📝 conformance/test-server/Cargo.toml (+0 -3)
📝 conformance/test-server/src/main.rs (+1 -1)
➖ crates/client/Cargo.toml (+0 -84)
➖ crates/client/LICENSE-APACHE (+0 -202)
➖ crates/client/LICENSE-MIT (+0 -20)
➖ crates/client/README.md (+0 -64)

...and 27 more files

📄 Description

I don't think it makes sense to maintain a separate README for client... (sorry, @cpu!).

As discussed previously in:

#3221

(But changing the ordering a little bit, since this is relatively trivial anyway.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3366 **Author:** [@djc](https://github.com/djc) **Created:** 11/27/2025 **Status:** ✅ Merged **Merged:** 11/27/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `merge-client` --- ### 📝 Commits (5) - [`ecefa51`](https://github.com/hickory-dns/hickory-dns/commit/ecefa51ef67cec431f400b058675efd8f86d38cc) bin: use bin crate version in logging - [`8706f57`](https://github.com/hickory-dns/hickory-dns/commit/8706f57de47caa1819e879bdb4d857a034c67a25) proto: fold client crate into proto::client - [`1d8ff51`](https://github.com/hickory-dns/hickory-dns/commit/1d8ff51cfe045a354349e874b59a23dc229e45c5) proto: regroup imports in client root - [`1cb0c71`](https://github.com/hickory-dns/hickory-dns/commit/1cb0c71b37b318b3dc26d240f142947331f9a40b) proto: fold client::client into client - [`35caf1d`](https://github.com/hickory-dns/hickory-dns/commit/35caf1d945f8d7f880a4748185c6b59f46b921fa) proto: collect client tests into separate file ### 📊 Changes **47 files changed** (+474 additions, -1058 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -25) 📝 `Cargo.toml` (+0 -2) 📝 `bin/Cargo.toml` (+0 -1) 📝 `bin/benches/comparison_benches.rs` (+1 -1) 📝 `bin/src/hickory-dns.rs` (+4 -4) 📝 `bin/tests/integration/named_https_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_metrics_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_quic_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_rustls_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+2 -2) 📝 `bin/tests/integration/named_tests.rs` (+1 -1) 📝 `bin/tests/integration/server_harness/mod.rs` (+2 -2) 📝 `bin/tests/integration/server_harness/mut_message_client.rs` (+1 -1) 📝 `conformance/Cargo.lock` (+0 -17) 📝 `conformance/test-server/Cargo.toml` (+0 -3) 📝 `conformance/test-server/src/main.rs` (+1 -1) ➖ `crates/client/Cargo.toml` (+0 -84) ➖ `crates/client/LICENSE-APACHE` (+0 -202) ➖ `crates/client/LICENSE-MIT` (+0 -20) ➖ `crates/client/README.md` (+0 -64) _...and 27 more files_ </details> ### 📄 Description I don't think it makes sense to maintain a separate README for client... (sorry, @cpu!). As discussed previously in: - #3221 (But changing the ordering a little bit, since this is relatively trivial anyway.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>