[PR #730] [MERGED] Asc screenshot dimensions #746

New issue

Closed

opened 2026-02-26 22:32:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/730
Author: @rudrankriyam
Created: 2/22/2026
Status: ✅ Merged
Merged: 2/23/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/asc-screenshot-dimensions-5f95

📝 Commits (7)

95f9c91 screenshots: add missing 6.7 and iPad 11 dimensions
a3c8f5a style: apply gofumpt alignment in screenshot sizes
0a587fd screenshots: align display-type sizing with ASC behavior
56ae9cb docs(screenshots): refresh examples to canonical API types
a7e1634 merge(main): sync screenshot dimensions branch with #744
01b55ae Fix iPhone 69 screenshot size alias consistency
52aaa12 Merge pull request #746 from rudrankriyam/cursor/iphone-69-67-dimensions-6280

📊 Changes

10 files changed (+776 additions, -212 deletions)

View changed files

📝 internal/asc/screenshot_sizes.go (+79 -139)
📝 internal/asc/screenshot_sizes_test.go (+203 -2)
📝 internal/cli/assets/assets_screenshots.go (+3 -2)
📝 internal/cli/cmdtest/assets_screenshots_sizes_test.go (+196 -0)
📝 internal/cli/migrate/import_helpers.go (+9 -8)
📝 internal/cli/migrate/screenshots.go (+13 -3)
📝 internal/cli/migrate/screenshots_test.go (+33 -0)
➕ internal/screenshotcatalog/catalog.go (+182 -0)
📝 internal/validation/screenshot_test.go (+52 -0)
📝 internal/validation/screenshots.go (+6 -58)

📄 Description

Summary

Adds missing App Store Connect (ASC) screenshot dimensions for iPhone 6.7" (1206x2622, 2622x1206) and iPad Pro 11" (3rd Gen) (1668x2420, 2420x1668) to the registry.
Expands unit and CLI test coverage to validate the newly added dimensions.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/730 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/22/2026 **Status:** ✅ Merged **Merged:** 2/23/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/asc-screenshot-dimensions-5f95` --- ### 📝 Commits (7) - [`95f9c91`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/95f9c91ddfe6f348c11180fd9963980e88c6d1c3) screenshots: add missing 6.7 and iPad 11 dimensions - [`a3c8f5a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a3c8f5a42b04eed3a264ef5d5dee4fe0ac2be5df) style: apply gofumpt alignment in screenshot sizes - [`0a587fd`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0a587fd080d585b2b53b56525f3e2273fc189464) screenshots: align display-type sizing with ASC behavior - [`56ae9cb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/56ae9cb7df392c5d11d088bfeee88aa989b3e996) docs(screenshots): refresh examples to canonical API types - [`a7e1634`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a7e1634686546f78f5a570d855a390137444d283) merge(main): sync screenshot dimensions branch with #744 - [`01b55ae`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/01b55aeb3ba9ff8c886173a346753a424455e318) Fix iPhone 69 screenshot size alias consistency - [`52aaa12`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/52aaa12372597ab5f713036c462b7c1aea8e00d0) Merge pull request #746 from rudrankriyam/cursor/iphone-69-67-dimensions-6280 ### 📊 Changes **10 files changed** (+776 additions, -212 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/screenshot_sizes.go` (+79 -139) 📝 `internal/asc/screenshot_sizes_test.go` (+203 -2) 📝 `internal/cli/assets/assets_screenshots.go` (+3 -2) 📝 `internal/cli/cmdtest/assets_screenshots_sizes_test.go` (+196 -0) 📝 `internal/cli/migrate/import_helpers.go` (+9 -8) 📝 `internal/cli/migrate/screenshots.go` (+13 -3) 📝 `internal/cli/migrate/screenshots_test.go` (+33 -0) ➕ `internal/screenshotcatalog/catalog.go` (+182 -0) 📝 `internal/validation/screenshot_test.go` (+52 -0) 📝 `internal/validation/screenshots.go` (+6 -58) </details> ### 📄 Description ## Summary - Adds missing App Store Connect (ASC) screenshot dimensions for iPhone 6.7" (1206x2622, 2622x1206) and iPad Pro 11" (3rd Gen) (1668x2420, 2420x1668) to the registry. - Expands unit and CLI test coverage to validate the newly added dimensions. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- <p><a href="https://cursor.com/agents?id=bc-ce16be37-6f58-4505-a44f-654e0c8fcd6a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-ce16be37-6f58-4505-a44f-654e0c8fcd6a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>