[PR #708] [MERGED] test(cli): add critical delete-path coverage #730

New issue

Closed

opened 2026-02-26 22:32:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/708
Author: @rudrankriyam
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: main ← Head: test/critical-delete-coverage

📝 Commits (1)

80bac33 test(cli): harden delete path coverage

📊 Changes

3 files changed (+284 additions, -0 deletions)

View changed files

📝 internal/asc/client_http_test.go (+68 -0)
📝 internal/cli/cmdtest/commands_test.go (+20 -0)
➕ internal/cli/cmdtest/delete_commands_output_test.go (+196 -0)

📄 Description

Summary

Add missing cmdtest coverage for localizations screenshot-sets delete and versions delete (required flag validation, success output, and API error propagation).
Extend central validation tests to assert missing --id / --confirm cases for the new and existing destructive commands.
Add HTTP contract tests for high-risk delete client methods: DeleteAppStoreVersion, DeleteSubscriptionGroup, DeleteSubscription, and DeleteUser.

Test plan

go test ./internal/cli/cmdtest -run "LocalizationsScreenshotSetsDelete|VersionsDelete|LocalizationsValidationErrors|VersionsValidationErrors" -count=1
go test ./internal/asc -run "DeleteAppStoreVersion|DeleteSubscriptionGroup|DeleteSubscription|DeleteUser_SendsRequest" -count=1
make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/708 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `test/critical-delete-coverage` --- ### 📝 Commits (1) - [`80bac33`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/80bac334817dc475d1add59de3297058a0304fba) test(cli): harden delete path coverage ### 📊 Changes **3 files changed** (+284 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_http_test.go` (+68 -0) 📝 `internal/cli/cmdtest/commands_test.go` (+20 -0) ➕ `internal/cli/cmdtest/delete_commands_output_test.go` (+196 -0) </details> ### 📄 Description ## Summary - Add missing cmdtest coverage for `localizations screenshot-sets delete` and `versions delete` (required flag validation, success output, and API error propagation). - Extend central validation tests to assert missing `--id` / `--confirm` cases for the new and existing destructive commands. - Add HTTP contract tests for high-risk delete client methods: `DeleteAppStoreVersion`, `DeleteSubscriptionGroup`, `DeleteSubscription`, and `DeleteUser`. ## Test plan - [x] `go test ./internal/cli/cmdtest -run "LocalizationsScreenshotSetsDelete|VersionsDelete|LocalizationsValidationErrors|VersionsValidationErrors" -count=1` - [x] `go test ./internal/asc -run "DeleteAppStoreVersion|DeleteSubscriptionGroup|DeleteSubscription|DeleteUser_SendsRequest" -count=1` - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>