[PR #746] [MERGED] Iphone 69/67 dimensions #758

New issue

Closed

opened 2026-02-26 22:32:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/746
Author: @cursor[bot]
Created: 2/23/2026
Status: ✅ Merged
Merged: 2/23/2026
Merged by: @rudrankriyam

Base: cursor/asc-screenshot-dimensions-5f95 ← Head: cursor/iphone-69-67-dimensions-6280

📝 Commits (1)

01b55ae Fix iPhone 69 screenshot size alias consistency

📊 Changes

2 files changed (+20 additions, -1 deletions)

View changed files

📝 internal/asc/screenshot_sizes_test.go (+20 -0)
📝 internal/screenshotcatalog/catalog.go (+0 -1)

📄 Description

Summary

Corrected inconsistent screenshot dimensions between APP_IPHONE_69 and its canonical APP_IPHONE_67. The 1284x2778 dimension is now correctly listed under APP_IPHONE_67, and removed from APP_IPHONE_69 to resolve the discrepancy where asc screenshots sizes --display-type APP_IPHONE_69 would show 1284x2778 as valid but asc screenshots upload --device-type IPHONE_69 would reject it.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/746 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/23/2026 **Status:** ✅ Merged **Merged:** 2/23/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/asc-screenshot-dimensions-5f95` ← **Head:** `cursor/iphone-69-67-dimensions-6280` --- ### 📝 Commits (1) - [`01b55ae`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/01b55aeb3ba9ff8c886173a346753a424455e318) Fix iPhone 69 screenshot size alias consistency ### 📊 Changes **2 files changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/screenshot_sizes_test.go` (+20 -0) 📝 `internal/screenshotcatalog/catalog.go` (+0 -1) </details> ### 📄 Description ## Summary - Corrected inconsistent screenshot dimensions between `APP_IPHONE_69` and its canonical `APP_IPHONE_67`. The `1284x2778` dimension is now correctly listed under `APP_IPHONE_67`, and removed from `APP_IPHONE_69` to resolve the discrepancy where `asc screenshots sizes --display-type APP_IPHONE_69` would show `1284x2778` as valid but `asc screenshots upload --device-type IPHONE_69` would reject it. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>