[PR #645] [CLOSED] Error hook duplication #678

New issue

Closed

opened 2026-02-26 22:32:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/645
Author: @cursor[bot]
Created: 2/18/2026
Status: ❌ Closed

Base: main ← Head: cursor/error-hook-duplication-c4a9

📝 Commits (1)

baf5e38 workflow: dedupe error hook recording

📊 Changes

1 file changed (+10 additions, -12 deletions)

View changed files

📝 internal/workflow/execute.go (+10 -12)

📄 Description

Summary

Refactored duplicated error hook invocation and recording logic into a helper function to improve maintainability and prevent inconsistencies.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/645 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/18/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cursor/error-hook-duplication-c4a9` --- ### 📝 Commits (1) - [`baf5e38`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/baf5e386ad5b2736c63ef44a7b5b185f8b10988b) workflow: dedupe error hook recording ### 📊 Changes **1 file changed** (+10 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `internal/workflow/execute.go` (+10 -12) </details> ### 📄 Description ## Summary - Refactored duplicated error hook invocation and recording logic into a helper function to improve maintainability and prevent inconsistencies. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>