[PR #599] [MERGED] TruncateNotes zero maxChars #645

New issue

Closed

opened 2026-02-26 22:31:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/599
Author: @cursor[bot]
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/17/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/truncatenotes-zero-maxchars-4cba

📝 Commits (1)

3675c25 Fix TruncateNotes zero maxChars handling

📊 Changes

2 files changed (+27 additions, -1 deletions)

View changed files

📝 internal/releasenotes/releasenotes.go (+7 -1)
📝 internal/releasenotes/releasenotes_test.go (+20 -0)

📄 Description

Summary

Fixes a bug in TruncateNotes where maxChars = 0 incorrectly returned the full input string instead of an empty string.
Adds a test case to verify the correct behavior for maxChars = 0.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/599 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/17/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/truncatenotes-zero-maxchars-4cba` --- ### 📝 Commits (1) - [`3675c25`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3675c25d88b6360335ac1224d63432ff6e416d8f) Fix TruncateNotes zero maxChars handling ### 📊 Changes **2 files changed** (+27 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/releasenotes/releasenotes.go` (+7 -1) 📝 `internal/releasenotes/releasenotes_test.go` (+20 -0) </details> ### 📄 Description ## Summary - Fixes a bug in `TruncateNotes` where `maxChars = 0` incorrectly returned the full input string instead of an empty string. - Adds a test case to verify the correct behavior for `maxChars = 0`. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>