[PR #678] [MERGED] Insights metrics reporting #707

New issue

Closed

opened 2026-02-26 22:32:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/678
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/account-insights-weekly ← Head: cursor/insights-metrics-reporting-64c2

📝 Commits (1)

fdd83c2 Fix insights sales report_rows availability handling

📊 Changes

2 files changed (+78 additions, -3 deletions)

View changed files

📝 internal/cli/cmdtest/insights_test.go (+68 -0)
📝 internal/cli/insights/insights.go (+10 -3)

📄 Description

Summary

Corrected report_rows metric to show "unavailable" status when data fetching fails, aligning its behavior with other metrics.
Renamed weekStart parameter to reportDate in fetchSalesWeekMetrics to accurately reflect that it receives the week's end date for the Apple API.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/678 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/account-insights-weekly` ← **Head:** `cursor/insights-metrics-reporting-64c2` --- ### 📝 Commits (1) - [`fdd83c2`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/fdd83c20fc6c7f8f3bbad12e5e853ff058f8ded6) Fix insights sales report_rows availability handling ### 📊 Changes **2 files changed** (+78 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/insights_test.go` (+68 -0) 📝 `internal/cli/insights/insights.go` (+10 -3) </details> ### 📄 Description ## Summary - Corrected `report_rows` metric to show "unavailable" status when data fetching fails, aligning its behavior with other metrics. - Renamed `weekStart` parameter to `reportDate` in `fetchSalesWeekMetrics` to accurately reflect that it receives the week's end date for the Apple API. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>