[PR #677] [MERGED] feat: add account status and weekly insights commands #704

New issue

Closed

opened 2026-02-26 22:32:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/677
Author: @rudrankriyam
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/account-insights-weekly

📝 Commits (10+)

e7958f7 feat: add account status and weekly insights commands
3e640d5 feat: complete #657 command and status UX gaps
e50d396 docs: require keychain bypass for all test runs
fdd83c2 Fix insights sales report_rows availability handling
d2526da Merge pull request #678 from rudrankriyam/cursor/insights-metrics-reporting-64c2
1bf053e cmdtest: reuse shared JSON response helper
da7d407 Merge pull request #679 from rudrankriyam/cursor/test-helper-duplication-7103
6f3f90c refactor shared section rendering and fix READY_FOR_REVIEW state symbol
c51936c Merge pull request #681 from rudrankriyam/cursor/cli-code-refinements-e449
780ccb4 feat: add renewal-focused insights daily and sales v1_3 support

📊 Changes

21 files changed (+2998 additions, -104 deletions)

View changed files

📝 AGENTS.md (+4 -1)
📝 cmd/root_usage.go (+3 -3)
📝 cmd/run_additional_test.go (+1 -1)
📝 internal/asc/analytics.go (+1 -0)
➕ internal/cli/account/account.go (+291 -0)
➕ internal/cli/account/account_test.go (+41 -0)
📝 internal/cli/analytics/analytics_helpers.go (+16 -1)
📝 internal/cli/analytics/analytics_helpers_test.go (+44 -0)
📝 internal/cli/analytics/analytics_sales.go (+3 -2)
➕ internal/cli/cmdtest/account_status_test.go (+187 -0)
➕ internal/cli/cmdtest/doctor_test.go (+41 -0)
➕ internal/cli/cmdtest/insights_test.go (+749 -0)
📝 internal/cli/cmdtest/status_test.go (+63 -19)
📝 internal/cli/docs/templates/ASC.md (+6 -0)
➕ internal/cli/insights/insights.go (+1171 -0)
➕ internal/cli/insights/insights_test.go (+96 -0)
📝 internal/cli/registry/registry.go (+5 -0)
📝 internal/cli/registry/registry_test.go (+1 -1)
📝 internal/cli/shared/shared.go (+23 -0)
📝 internal/cli/status/status.go (+204 -75)

...and 1 more files

📄 Description

Summary

Add asc account status with structured account health checks (authentication, API access probe, agreements availability) and JSON/table/markdown output.
Add asc insights weekly with required --app, --source, and --week, deterministic week-range metadata, and source-specific metrics for analytics and sales.
Wire new command groups into root registry/help buckets and update the ASC command reference template.
Add comprehensive tests: package tests + command tests for validation, JSON contracts, table rendering, and restricted-permission fallback paths.

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test
Live smoke: ASC_BYPASS_KEYCHAIN=1 /tmp/asc account status --output json
Live smoke: ASC_BYPASS_KEYCHAIN=1 /tmp/asc insights weekly --app "$ASC_APP_ID" --source analytics --week "2026-02-16" --output json
Live smoke: ASC_BYPASS_KEYCHAIN=1 /tmp/asc insights weekly --app "$ASC_APP_ID" --source sales --week "2026-02-16" --vendor "$ASC_VENDOR_NUMBER" --output json

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/677 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/account-insights-weekly` --- ### 📝 Commits (10+) - [`e7958f7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e7958f798626c86fa8fd12996aa9123ba1f7c4c4) feat: add account status and weekly insights commands - [`3e640d5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3e640d54457b2f44982706fef98b007acea2f431) feat: complete #657 command and status UX gaps - [`e50d396`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e50d3960fcbf3a7947bbf666652014af8eddf8be) docs: require keychain bypass for all test runs - [`fdd83c2`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/fdd83c20fc6c7f8f3bbad12e5e853ff058f8ded6) Fix insights sales report_rows availability handling - [`d2526da`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d2526da7f7926f278766d46abbc6789b718e560c) Merge pull request #678 from rudrankriyam/cursor/insights-metrics-reporting-64c2 - [`1bf053e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1bf053ea0e19f829fdac4768c5959133024098ad) cmdtest: reuse shared JSON response helper - [`da7d407`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/da7d407d8d2ce54166b8ccc5c127906d730086f7) Merge pull request #679 from rudrankriyam/cursor/test-helper-duplication-7103 - [`6f3f90c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6f3f90c2ea8028e1c8308634dcf0d2912574272f) refactor shared section rendering and fix READY_FOR_REVIEW state symbol - [`c51936c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c51936cd4269ec13cbe89b198f03e140da314201) Merge pull request #681 from rudrankriyam/cursor/cli-code-refinements-e449 - [`780ccb4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/780ccb47170b7829971775b556509f88ab2a1efa) feat: add renewal-focused insights daily and sales v1_3 support ### 📊 Changes **21 files changed** (+2998 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `AGENTS.md` (+4 -1) 📝 `cmd/root_usage.go` (+3 -3) 📝 `cmd/run_additional_test.go` (+1 -1) 📝 `internal/asc/analytics.go` (+1 -0) ➕ `internal/cli/account/account.go` (+291 -0) ➕ `internal/cli/account/account_test.go` (+41 -0) 📝 `internal/cli/analytics/analytics_helpers.go` (+16 -1) 📝 `internal/cli/analytics/analytics_helpers_test.go` (+44 -0) 📝 `internal/cli/analytics/analytics_sales.go` (+3 -2) ➕ `internal/cli/cmdtest/account_status_test.go` (+187 -0) ➕ `internal/cli/cmdtest/doctor_test.go` (+41 -0) ➕ `internal/cli/cmdtest/insights_test.go` (+749 -0) 📝 `internal/cli/cmdtest/status_test.go` (+63 -19) 📝 `internal/cli/docs/templates/ASC.md` (+6 -0) ➕ `internal/cli/insights/insights.go` (+1171 -0) ➕ `internal/cli/insights/insights_test.go` (+96 -0) 📝 `internal/cli/registry/registry.go` (+5 -0) 📝 `internal/cli/registry/registry_test.go` (+1 -1) 📝 `internal/cli/shared/shared.go` (+23 -0) 📝 `internal/cli/status/status.go` (+204 -75) _...and 1 more files_ </details> ### 📄 Description ## Summary - Add `asc account status` with structured account health checks (authentication, API access probe, agreements availability) and JSON/table/markdown output. - Add `asc insights weekly` with required `--app`, `--source`, and `--week`, deterministic week-range metadata, and source-specific metrics for `analytics` and `sales`. - Wire new command groups into root registry/help buckets and update the ASC command reference template. - Add comprehensive tests: package tests + command tests for validation, JSON contracts, table rendering, and restricted-permission fallback paths. ## Test plan - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` - [x] Live smoke: `ASC_BYPASS_KEYCHAIN=1 /tmp/asc account status --output json` - [x] Live smoke: `ASC_BYPASS_KEYCHAIN=1 /tmp/asc insights weekly --app "$ASC_APP_ID" --source analytics --week "2026-02-16" --output json` - [x] Live smoke: `ASC_BYPASS_KEYCHAIN=1 /tmp/asc insights weekly --app "$ASC_APP_ID" --source sales --week "2026-02-16" --vendor "$ASC_VENDOR_NUMBER" --output json` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>