[PR #1220] [MERGED] Return 404 instead of fallback icon #2917

New issue

Closed

opened 2026-03-03 09:08:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:08:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1220
Author: @jameshurst
Created: 11/10/2020
Status: ✅ Merged
Merged: 11/14/2020
Merged by: @dani-garcia

Base: master ← Head: master

📝 Commits (2)

ed70b07 Return 404 instead of fallback icon
7712331 Fix for negcached icons

📊 Changes

2 files changed (+16 additions, -18 deletions)

View changed files

📝 src/api/icons.rs (+16 -18)
➖ src/static/fallback-icon.png (+0 -0)

📄 Description

Returning a 404 not found error instead of the fallback icon allows clients to use their own icon instead (which may be higher quality than the fallback icon). This behaviour matches that of the official icons server as well (https://github.com/bitwarden/server/blob/master/src/Icons/Controllers/IconsController.cs#L89-L93).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1220 **Author:** [@jameshurst](https://github.com/jameshurst) **Created:** 11/10/2020 **Status:** ✅ Merged **Merged:** 11/14/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`ed70b07`](https://github.com/dani-garcia/vaultwarden/commit/ed70b07d8184a6e5c3bb048af15386fb68b647c6) Return 404 instead of fallback icon - [`7712331`](https://github.com/dani-garcia/vaultwarden/commit/771233176fd108e0537c5dc5456c5c09cd8d1ef8) Fix for negcached icons ### 📊 Changes **2 files changed** (+16 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+16 -18) ➖ `src/static/fallback-icon.png` (+0 -0) </details> ### 📄 Description Returning a 404 not found error instead of the fallback icon allows clients to use their own icon instead (which may be higher quality than the fallback icon). This behaviour matches that of the official icons server as well (https://github.com/bitwarden/server/blob/master/src/Icons/Controllers/IconsController.cs#L89-L93). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>