[PR #3404] [MERGED] WebSockets via Rocket's Upgrade connection #3282

New issue

Closed

opened 2026-03-03 09:58:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:58:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3404
Author: @BlackDex
Created: 3/31/2023
Status: ✅ Merged
Merged: 4/10/2023
Merged by: @dani-garcia

Base: main ← Head: websockets-via-rocket

📝 Commits (1)

3d11f4c WebSockets via Rocket's Upgrade connection

📊 Changes

3 files changed (+344 additions, -192 deletions)

View changed files

📝 Cargo.lock (+179 -107)
📝 Cargo.toml (+11 -6)
📝 src/api/notifications.rs (+154 -79)

📄 Description

This PR implements a (not yet fully released) new feature of Rocket which allows WebSockets/Upgrade connections.
No more need for multiple ports to be opened for Vaultwarden.
No explicit need for a reverse proxy to get WebSockets to work (Although I still suggest to use a reverse proxy).

Using a git revision for Rocket, since rocket_ws is not yet released.
Updated other crates as well.
Added a connection guard to clear the WS connection from the Users list.

Fixes #685
Fixes #2917
Fixes #1424

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3404 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 3/31/2023 **Status:** ✅ Merged **Merged:** 4/10/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `websockets-via-rocket` --- ### 📝 Commits (1) - [`3d11f4c`](https://github.com/dani-garcia/vaultwarden/commit/3d11f4cd16d8464835fb684e7c5528eb54ed535d) WebSockets via Rocket's Upgrade connection ### 📊 Changes **3 files changed** (+344 additions, -192 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+179 -107) 📝 `Cargo.toml` (+11 -6) 📝 `src/api/notifications.rs` (+154 -79) </details> ### 📄 Description This PR implements a (not yet fully released) new feature of Rocket which allows WebSockets/Upgrade connections. No more need for multiple ports to be opened for Vaultwarden. No explicit need for a reverse proxy to get WebSockets to work (Although I still suggest to use a reverse proxy). - Using a git revision for Rocket, since `rocket_ws` is not yet released. - Updated other crates as well. - Added a connection guard to clear the WS connection from the Users list. Fixes #685 Fixes #2917 Fixes #1424 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>