[PR #61] [MERGED] convert JavaScript to TypeScript #68

New issue

Closed

opened 2026-03-03 01:21:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/61
Author: @cs01
Created: 7/11/2021
Status: ✅ Merged
Merged: 7/11/2021
Merged by: @cs01

Base: master ← Head: cs01/js-to-typescript

📝 Commits (2)

4e1d9e1 use typescript
89af89f migrate to typescript

📊 Changes

12 files changed (+202 additions, -37 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 termpair/frontend_src/package.json (+5 -0)
➖ termpair/frontend_src/src/App.test.js (+0 -9)
➕ termpair/frontend_src/src/App.test.tsx (+9 -0)
📝 termpair/frontend_src/src/App.tsx (+36 -14)
📝 termpair/frontend_src/src/encryption.tsx (+14 -8)
➕ termpair/frontend_src/src/global.d.ts (+1 -0)
📝 termpair/frontend_src/src/index.tsx (+0 -0)
➕ termpair/frontend_src/src/react-app-env.d.ts (+1 -0)
📝 termpair/frontend_src/src/serviceWorker.ts (+3 -3)
➕ termpair/frontend_src/tsconfig.json (+25 -0)
📝 termpair/frontend_src/yarn.lock (+107 -3)

📄 Description

I have added an entry to CHANGELOG.md

Summary of changes

Convert JavaScript code to TypeScript:

add types with yarn add typescript @types/node @types/react @types/react-dom @types/jest
auto-migrate with ts-migrate: https://github.com/airbnb/ts-migrate/tree/master/packages/ts-migrate#usage

This was actually a relatively painless experience. The tooling around javscript/typescript is getting really nice!

Test plan

Tested by running

yarn build

closes #60

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/61 **Author:** [@cs01](https://github.com/cs01) **Created:** 7/11/2021 **Status:** ✅ Merged **Merged:** 7/11/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/js-to-typescript` --- ### 📝 Commits (2) - [`4e1d9e1`](https://github.com/cs01/termpair/commit/4e1d9e165610b1327b9c300ddec09d3ff8b6b714) use typescript - [`89af89f`](https://github.com/cs01/termpair/commit/89af89f5d788186813f19a129e876061e7e7fe9f) migrate to typescript ### 📊 Changes **12 files changed** (+202 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `termpair/frontend_src/package.json` (+5 -0) ➖ `termpair/frontend_src/src/App.test.js` (+0 -9) ➕ `termpair/frontend_src/src/App.test.tsx` (+9 -0) 📝 `termpair/frontend_src/src/App.tsx` (+36 -14) 📝 `termpair/frontend_src/src/encryption.tsx` (+14 -8) ➕ `termpair/frontend_src/src/global.d.ts` (+1 -0) 📝 `termpair/frontend_src/src/index.tsx` (+0 -0) ➕ `termpair/frontend_src/src/react-app-env.d.ts` (+1 -0) 📝 `termpair/frontend_src/src/serviceWorker.ts` (+3 -3) ➕ `termpair/frontend_src/tsconfig.json` (+25 -0) 📝 `termpair/frontend_src/yarn.lock` (+107 -3) </details> ### 📄 Description  * [x] I have added an entry to `CHANGELOG.md` ## Summary of changes Convert JavaScript code to TypeScript: * add types with `yarn add typescript @types/node @types/react @types/react-dom @types/jest` * auto-migrate with ts-migrate: https://github.com/airbnb/ts-migrate/tree/master/packages/ts-migrate#usage This was actually a relatively painless experience. The tooling around javscript/typescript is getting really nice! ## Test plan  Tested by running ``` yarn build ``` closes #60 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>