[PR #68] [MERGED] resize on connection+other improvements #74

New issue

Closed

opened 2026-03-03 01:21:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/68
Author: @cs01
Created: 7/23/2021
Status: ✅ Merged
Merged: 7/23/2021
Merged by: @cs01

Base: master ← Head: cs01/resize-on-connection

📝 Commits (4)

fe3bbad resize on initial connection
e77268d redo landing page
38ce116 make websocket subprotocol compatible with older clients
5d301b0 fix lint

📊 Changes

14 files changed (+403 additions, -147 deletions)

View changed files

📝 .flake8 (+1 -1)
📝 CHANGELOG.md (+3 -0)
📝 setup.py (+2 -2)
➕ termpair/Terminal.py (+19 -0)
➕ termpair/constants.py (+8 -0)
📝 termpair/frontend_src/package.json (+3 -1)
📝 termpair/frontend_src/src/App.tsx (+140 -39)
➕ termpair/frontend_src/src/events.tsx (+15 -0)
📝 termpair/frontend_src/src/index.css (+15 -0)
📝 termpair/frontend_src/yarn.lock (+28 -1)
📝 termpair/main.py (+4 -5)
📝 termpair/server.py (+53 -53)
➕ termpair/server_websocket_subprotocol_handlers.py (+26 -0)
📝 termpair/share.py (+86 -45)

📄 Description

I have added an entry to CHANGELOG.md

Summary of changes

Browser requests current size of terminal upon websocket connection
This required a new subprotocol on the websocket
Improved error handling on client and server
Ended up redesigning some of the UI
Since the UI changed so much and the subprotocol handling changed, I made this a major version bump

Test plan

Tested by running

yarn build
nox -s serve
# in new terminal
nox -s broadcast

closes #62

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/68 **Author:** [@cs01](https://github.com/cs01) **Created:** 7/23/2021 **Status:** ✅ Merged **Merged:** 7/23/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/resize-on-connection` --- ### 📝 Commits (4) - [`fe3bbad`](https://github.com/cs01/termpair/commit/fe3bbada843d8293bdda0982ea3a2793a802f808) resize on initial connection - [`e77268d`](https://github.com/cs01/termpair/commit/e77268d9f24d2347dba15f21eabbe779186e19e4) redo landing page - [`38ce116`](https://github.com/cs01/termpair/commit/38ce1168342bf105d5fc82b055dafa6ca345e36c) make websocket subprotocol compatible with older clients - [`5d301b0`](https://github.com/cs01/termpair/commit/5d301b0583892cb6ae4405e33708dced63013817) fix lint ### 📊 Changes **14 files changed** (+403 additions, -147 deletions) <details> <summary>View changed files</summary> 📝 `.flake8` (+1 -1) 📝 `CHANGELOG.md` (+3 -0) 📝 `setup.py` (+2 -2) ➕ `termpair/Terminal.py` (+19 -0) ➕ `termpair/constants.py` (+8 -0) 📝 `termpair/frontend_src/package.json` (+3 -1) 📝 `termpair/frontend_src/src/App.tsx` (+140 -39) ➕ `termpair/frontend_src/src/events.tsx` (+15 -0) 📝 `termpair/frontend_src/src/index.css` (+15 -0) 📝 `termpair/frontend_src/yarn.lock` (+28 -1) 📝 `termpair/main.py` (+4 -5) 📝 `termpair/server.py` (+53 -53) ➕ `termpair/server_websocket_subprotocol_handlers.py` (+26 -0) 📝 `termpair/share.py` (+86 -45) </details> ### 📄 Description  * [x] I have added an entry to `CHANGELOG.md` ## Summary of changes * Browser requests current size of terminal upon websocket connection * This required a new subprotocol on the websocket * Improved error handling on client and server * Ended up redesigning some of the UI * Since the UI changed so much and the subprotocol handling changed, I made this a major version bump ## Test plan  Tested by running ``` yarn build nox -s serve # in new terminal nox -s broadcast ``` closes #62 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>