mirror of
https://github.com/cs01/termpair.git
synced 2026-04-26 21:15:55 +03:00
[PR #49] [MERGED] allow frontend to be served statically #61
Labels
No labels
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/termpair#61
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/cs01/termpair/pull/49
Author: @cs01
Created: 6/3/2021
Status: ✅ Merged
Merged: 8/6/2021
Merged by: @cs01
Base:
master← Head:cs01/standalone-frontend📝 Commits (7)
3bd3c3fstatically hosted page works1bc68d8fix lint errorca9790bcss updates; doc updates; allow terminal id to be entered on regular server0093b9fupdate noxfilea84079badd link to static site in readmeb8bdf0ffix typos68479ffput inputs in a form so they are remembered📊 Changes
10 files changed (+422 additions, -114 deletions)
View changed files
📝
CHANGELOG.md(+6 -0)📝
CONTRIBUTING.md(+14 -4)📝
README.md(+25 -11)📝
docs/termpair_architecture.excalidraw(+5 -5)📝
docs/termpair_architecture.png(+0 -0)📝
noxfile.py(+18 -0)📝
termpair/frontend_src/package.json(+0 -1)📝
termpair/frontend_src/src/App.tsx(+307 -69)📝
termpair/server.py(+15 -0)📝
termpair/share.py(+32 -24)📄 Description
This implements a static frontend as suggested in #36.
background
Currently, the browser contains decrypted data and the encryption key. If the browser's JavaScript were modified to be malicious and a malicious server were created, it would be hard to detect.
this pr
This PR allows the backend to accept cross origin requests, and the frontend to be served statically on GitHub pages, Vercel, or a local static server, which can be manually built. The static page still routes the terminal traffic through a (potentially) untrusted server, but that is okay since the traffic is encrypted before going over the wire.
Changes
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.