[PR #2129] [CLOSED] Feature: Add properties field in data source schema for model computed properties #3852

New issue

Closed

opened 2026-03-14 07:42:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 07:42:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/2129
Author: @sadnub
Created: 1/27/2025
Status: ❌ Closed

Base: develop ← Head: feat-nexturl

📝 Commits (8)

1addf57 Allow querying agent notes in reporting
29042b2 allow querying computed properties on models
dcc5f6c get @property fields dynamically
0d81204 black
21a9505 fix related fields
c7f84a9 add additional processing and checks if select_related is passed. Added test cases
66f854a fix datetime conversion in serializer. Added more tests
1e86382 remove serializer and modify add_custom_fields function to also add properties if specified

📊 Changes

6 files changed (+400 additions, -99 deletions)

View changed files

📝 api/tacticalrmm/ee/reporting/constants.py (+27 -0)
📝 api/tacticalrmm/ee/reporting/management/commands/generate_json_schemas.py (+13 -1)
📝 api/tacticalrmm/ee/reporting/tests/test_data_queries.py (+187 -30)
📝 api/tacticalrmm/ee/reporting/tests/test_import_export_template_views.py (+0 -1)
📝 api/tacticalrmm/ee/reporting/tests/test_template_generation.py (+68 -1)
📝 api/tacticalrmm/ee/reporting/utils.py (+105 -66)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/2129 **Author:** [@sadnub](https://github.com/sadnub) **Created:** 1/27/2025 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `feat-nexturl` --- ### 📝 Commits (8) - [`1addf57`](https://github.com/amidaware/tacticalrmm/commit/1addf57ef049ddb05f865da70db47e87e7f84e8b) Allow querying agent notes in reporting - [`29042b2`](https://github.com/amidaware/tacticalrmm/commit/29042b2c62ced40257a0d6274c8f6c54de0c503e) allow querying computed properties on models - [`dcc5f6c`](https://github.com/amidaware/tacticalrmm/commit/dcc5f6cccf701ab3fc33334b6607c46588bc3231) get @property fields dynamically - [`0d81204`](https://github.com/amidaware/tacticalrmm/commit/0d8120445aff47a45606efd4e7ec1fd74ec4e946) black - [`21a9505`](https://github.com/amidaware/tacticalrmm/commit/21a9505c9cb13f62392fd95ad7954f5c14804c50) fix related fields - [`c7f84a9`](https://github.com/amidaware/tacticalrmm/commit/c7f84a91c7398adf21f877e658140c420eb40aba) add additional processing and checks if select_related is passed. Added test cases - [`66f854a`](https://github.com/amidaware/tacticalrmm/commit/66f854aa83bc1d1e2514d8cae38b5504c276d30e) fix datetime conversion in serializer. Added more tests - [`1e86382`](https://github.com/amidaware/tacticalrmm/commit/1e863825f4dfe72b4957830a0bed267e29ffb002) remove serializer and modify add_custom_fields function to also add properties if specified ### 📊 Changes **6 files changed** (+400 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `api/tacticalrmm/ee/reporting/constants.py` (+27 -0) 📝 `api/tacticalrmm/ee/reporting/management/commands/generate_json_schemas.py` (+13 -1) 📝 `api/tacticalrmm/ee/reporting/tests/test_data_queries.py` (+187 -30) 📝 `api/tacticalrmm/ee/reporting/tests/test_import_export_template_views.py` (+0 -1) 📝 `api/tacticalrmm/ee/reporting/tests/test_template_generation.py` (+68 -1) 📝 `api/tacticalrmm/ee/reporting/utils.py` (+105 -66) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>