mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 15:05:57 +03:00
[GH-ISSUE #285] Recommendation: Move credentials for postgres DB in backup script to separate file #2129
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#2129
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @knk90 on GitHub (Feb 18, 2021).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/285
Originally assigned to: @wh1te909 on GitHub.
Currently /rmm/backup.sh needs to be modified on every upgrade to include the postgres DB creds.
Recommend these are read from a separate file or similar which does not get overwritten on every trmm update.
@dinger1986 commented on GitHub (Feb 21, 2021):
Download the backup file directly and store it in /home/your-user as the only reason its in /rmm/ is due to it doing git clone to there, you will see the install.sh file and others are in there as well.
wget https://raw.githubusercontent.com/wh1te909/tacticalrmm/master/backup.sh
@wh1te909 commented on GitHub (Feb 24, 2021):
@dinger1986 im gonna reopen, this is a good request cuz now if I update the backup script it requires you to redownload the latest one and then edit the username/password again. so if the creds are in a different file then the backup script can just be re-run without having to edit it again
@wh1te909 commented on GitHub (Feb 24, 2021):
ok so this is added, thank you @dinger1986 for writing the new grep command to grab the username/password from local_settings.py
@knk90 I've updated the documentation site with new instructions. You can just run both
backup.shandrestore.shwithout editing anything.