[PR #107] [MERGED] [#97] Refactor default themes #628

New issue

Closed

opened 2026-03-02 23:49:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/107
Author: @aome510
Created: 1/16/2023
Status: ✅ Merged
Merged: 1/17/2023
Merged by: @aome510

Base: master ← Head: 97-refactor-default-theme

📝 Commits (9)

88fe659 removed built-in themes and used ansi theme as the only default
5057f4c remove selection_background and selection_foreground from theme's palette
a464a6b make background and foreground an optional field in theme's palette
8fbef48 tweak default component styles
43f1282 update theme_parse script
ee26edc update example config files to reflect new default theme changes
8339675 implement serde::default for ANSI colors in theme's Palette struct
f1218c7 add gruvbox_light theme to example theme config
5b5eff3 update configuration documentation

📊 Changes

5 files changed (+263 additions, -181 deletions)

View changed files

📝 doc/config.md (+13 -12)
📝 examples/app.toml (+1 -1)
📝 examples/theme.toml (+118 -26)
📝 scripts/theme_parse (+22 -18)
📝 spotify_player/src/config/theme.rs (+109 -124)

📄 Description

Resolves #97

TODO

remove built-in themes in favour of a single default ANSI theme
update theme_parse script
update theme/palette documentation
update theme.toml and app.toml examples

Theme config changes

made background and foreground fields optional in a theme's palette. Default to use terminal's background/foreground colors if not specified.
made 16 ANSI color fields optional in a theme's palette. Default to use terminal's ANSI colors if not specified.
removed selection_background and selection_foreground fields from a theme's palette
tweaked default value for playback_progress_bar component style

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/107 **Author:** [@aome510](https://github.com/aome510) **Created:** 1/16/2023 **Status:** ✅ Merged **Merged:** 1/17/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `97-refactor-default-theme` --- ### 📝 Commits (9) - [`88fe659`](https://github.com/aome510/spotify-player/commit/88fe659fab708b302b8fb5adb0e6b2c379c23e35) removed built-in themes and used ansi theme as the only default - [`5057f4c`](https://github.com/aome510/spotify-player/commit/5057f4c9975d9801e1d812ee1466340050094871) remove `selection_background` and `selection_foreground` from theme's palette - [`a464a6b`](https://github.com/aome510/spotify-player/commit/a464a6b518ea2668c3ad4b6dfc20b9253475c9c2) make `background` and `foreground` an optional field in theme's palette - [`8fbef48`](https://github.com/aome510/spotify-player/commit/8fbef480e684b8d4015981216c2b0193c73bda16) tweak default component styles - [`43f1282`](https://github.com/aome510/spotify-player/commit/43f1282af0dda397bec047846922712a408623c5) update `theme_parse` script - [`ee26edc`](https://github.com/aome510/spotify-player/commit/ee26edcd1caea1a94a2795817a679bdc5968675d) update example config files to reflect new default theme changes - [`8339675`](https://github.com/aome510/spotify-player/commit/8339675be6fc3ceee806b2527123a28e8c08cbe6) implement `serde::default` for ANSI colors in theme's Palette struct - [`f1218c7`](https://github.com/aome510/spotify-player/commit/f1218c74191d8aa90154d2310fb82cf4fa99f912) add `gruvbox_light` theme to example theme config - [`5b5eff3`](https://github.com/aome510/spotify-player/commit/5b5eff36d10205d43e3250cfe9c3b2afe277c48c) update configuration documentation ### 📊 Changes **5 files changed** (+263 additions, -181 deletions) <details> <summary>View changed files</summary> 📝 `doc/config.md` (+13 -12) 📝 `examples/app.toml` (+1 -1) 📝 `examples/theme.toml` (+118 -26) 📝 `scripts/theme_parse` (+22 -18) 📝 `spotify_player/src/config/theme.rs` (+109 -124) </details> ### 📄 Description Resolves #97 ## TODO - [x] remove built-in themes in favour of a single default ANSI theme - [x] update `theme_parse` script - [x] update theme/palette documentation - [x] update `theme.toml` and `app.toml` examples ## Theme config changes - made `background` and `foreground` fields optional in a theme's palette. Default to use terminal's background/foreground colors if not specified. - made 16 ANSI color fields optional in a theme's palette. Default to use terminal's ANSI colors if not specified. - removed `selection_background` and `selection_foreground` fields from a theme's palette - tweaked default value for `playback_progress_bar` component style --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>