[PR #638] [CLOSED] fix build with sixel feature on windows #1766

Closed
opened 2026-03-14 15:31:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/638
Author: @juliamertz
Created: 12/16/2024
Status: Closed

Base: masterHead: fix-sixel


📝 Commits (3)

  • c02087e use experimental icy_sixel
  • 37db090 use own fork without sixelrs dep
  • a3100a3 change viuer branch & revert some changes

📊 Changes

3 files changed (+20 additions, -13 deletions)

View changed files

📝 Cargo.lock (+17 -11)
📝 spotify_player/Cargo.toml (+2 -1)
📝 spotify_player/src/main.rs (+1 -1)

📄 Description

There's an open pull request for viuer adding support for the native icy_sixel implementation: https://github.com/atanunq/viuer/pull/63. However, I currently can't get that branch to work without pulling in the broken sixel-sys dependency.

For now, I've forked that PR's branch and removed the old sixel dependencies, which allows the Windows build to succeed again. I'll leave this here as a draft until that PR is merged.

This should also fix #628


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/638 **Author:** [@juliamertz](https://github.com/juliamertz) **Created:** 12/16/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-sixel` --- ### 📝 Commits (3) - [`c02087e`](https://github.com/aome510/spotify-player/commit/c02087eb4b259baa709fc795572ef293cba5f301) use experimental icy_sixel - [`37db090`](https://github.com/aome510/spotify-player/commit/37db090961ac4fe2e5f54da230a30ec3a1c7cd3b) use own fork without sixelrs dep - [`a3100a3`](https://github.com/aome510/spotify-player/commit/a3100a316ab4ec5b308bdedb5f3e4e0e5c30c15b) change viuer branch & revert some changes ### 📊 Changes **3 files changed** (+20 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+17 -11) 📝 `spotify_player/Cargo.toml` (+2 -1) 📝 `spotify_player/src/main.rs` (+1 -1) </details> ### 📄 Description There's an open pull request for `viuer` adding support for the native `icy_sixel` implementation: https://github.com/atanunq/viuer/pull/63. However, I currently can't get that branch to work without pulling in the broken `sixel-sys` dependency. For now, I've forked that PR's branch and removed the old sixel dependencies, which allows the Windows build to succeed again. I'll leave this here as a draft until that PR is merged. This should also fix #628 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:31:48 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1766
No description provided.