mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[PR #638] [CLOSED] fix build with sixel feature on windows #827
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#827
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/aome510/spotify-player/pull/638
Author: @juliamertz
Created: 12/16/2024
Status: ❌ Closed
Base:
master← Head:fix-sixel📝 Commits (3)
c02087euse experimental icy_sixel37db090use own fork without sixelrs depa3100a3change viuer branch & revert some changes📊 Changes
3 files changed (+20 additions, -13 deletions)
View changed files
📝
Cargo.lock(+17 -11)📝
spotify_player/Cargo.toml(+2 -1)📝
spotify_player/src/main.rs(+1 -1)📄 Description
There's an open pull request for
viueradding support for the nativeicy_sixelimplementation: https://github.com/atanunq/viuer/pull/63. However, I currently can't get that branch to work without pulling in the brokensixel-sysdependency.For now, I've forked that PR's branch and removed the old sixel dependencies, which allows the Windows build to succeed again. I'll leave this here as a draft until that PR is merged.
This should also fix #628
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.