[PR #780] [MERGED] refactor: allow specific sqlite engine for OpenBSD #787

New issue

Closed

opened 2026-02-25 23:35:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/780
Author: @pacoesteban
Created: 11/16/2023
Status: ✅ Merged
Merged: 5/2/2024
Merged by: @fmartingr

Base: master ← Head: syscall-removal

📝 Commits (10+)

fb0856b remove dependencies that use syscall.Syscall*
3656e13 add ~emersion/go-sqlite3-fts5
eee297e enable cgo to check ci
e942770 fts5 build flag
00f0aff split sqlite logic using build flags
a7937f3 disable cgo again
6720944 Merge remote-tracking branch 'origin/master' into pr/pacoesteban/780
eadddca Merge remote-tracking branch 'origin/master' into pr/pacoesteban/780
46de6af Merge branch 'master' into syscall-removal
e4a25b8 Merge remote-tracking branch 'origin/master' into syscall-removal

📊 Changes

7 files changed (+94 additions, -18 deletions)

View changed files

📝 .github/workflows/_test.yml (+34 -1)
📝 Makefile (+5 -5)
📝 go.mod (+2 -0)
📝 go.sum (+2 -0)
📝 internal/database/sqlite.go (+0 -12)
➕ internal/database/sqlite_noncgo.go (+25 -0)
➕ internal/database/sqlite_openbsd.go (+26 -0)

📄 Description

OpenBSD will be removing direct access to syscall(2) soon. Shiori will stop working because of this, as some of its dependencies rely heavily on the use of syscall.Syscall*, which ends up using syscall(2). This commit removes those dependencies by reverting back to use github.com/mattn/go-sqlite3 instead of modernc.org/sqlite to deal with the sqlite database backend.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/780 **Author:** [@pacoesteban](https://github.com/pacoesteban) **Created:** 11/16/2023 **Status:** ✅ Merged **Merged:** 5/2/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `syscall-removal` --- ### 📝 Commits (10+) - [`fb0856b`](https://github.com/go-shiori/shiori/commit/fb0856bad0b48174065bd522344296a70e6a0cb6) remove dependencies that use syscall.Syscall* - [`3656e13`](https://github.com/go-shiori/shiori/commit/3656e130a894e51a106352adcab90d072a85e2f1) add ~emersion/go-sqlite3-fts5 - [`eee297e`](https://github.com/go-shiori/shiori/commit/eee297e14751865bf0f17a5103fa5ffeb286b740) enable cgo to check ci - [`e942770`](https://github.com/go-shiori/shiori/commit/e9427707a2b7c6d39e469ff75a4afafa4149c95c) fts5 build flag - [`00f0aff`](https://github.com/go-shiori/shiori/commit/00f0aff24309663e4c5e1a1169ee568860fe28d8) split sqlite logic using build flags - [`a7937f3`](https://github.com/go-shiori/shiori/commit/a7937f32134133733553cd07d6f610007b39a686) disable cgo again - [`6720944`](https://github.com/go-shiori/shiori/commit/6720944ff11c36135f3dfda1c874391c12cf70fd) Merge remote-tracking branch 'origin/master' into pr/pacoesteban/780 - [`eadddca`](https://github.com/go-shiori/shiori/commit/eadddca4c37c93de9e39d8fba5a179d4fcef8e3e) Merge remote-tracking branch 'origin/master' into pr/pacoesteban/780 - [`46de6af`](https://github.com/go-shiori/shiori/commit/46de6af007a22dbd85d988b6df0ded2e971db09e) Merge branch 'master' into syscall-removal - [`e4a25b8`](https://github.com/go-shiori/shiori/commit/e4a25b83b254f5653787ac9134ed846416c05901) Merge remote-tracking branch 'origin/master' into syscall-removal ### 📊 Changes **7 files changed** (+94 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/_test.yml` (+34 -1) 📝 `Makefile` (+5 -5) 📝 `go.mod` (+2 -0) 📝 `go.sum` (+2 -0) 📝 `internal/database/sqlite.go` (+0 -12) ➕ `internal/database/sqlite_noncgo.go` (+25 -0) ➕ `internal/database/sqlite_openbsd.go` (+26 -0) </details> ### 📄 Description OpenBSD will be removing direct access to `syscall(2)` soon. Shiori will stop working because of this, as some of its dependencies rely heavily on the use of `syscall.Syscall*`, which ends up using `syscall(2)`. This commit removes those dependencies by reverting back to use github.com/mattn/go-sqlite3 instead of modernc.org/sqlite to deal with the sqlite database backend. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>