[PR #764] [MERGED] chore: frontend formatting #780

New issue

Closed

opened 2026-02-25 23:35:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/764
Author: @cbe
Created: 10/17/2023
Status: ✅ Merged
Merged: 11/5/2023
Merged by: @fmartingr

Base: master ← Head: frontend_formatting

📝 Commits (9)

46ec50e Install prettier
23881d5 Configure prettier
e2af5dc Check & format with prettier when compiling less
a099933 Update docs to use bun
f649720 Check actual result of prettier
4c6eb19 Use LF line endings
1676e5d Limit prettier to internal/view/
38351bc Merge remote-tracking branch 'master' into frontend_formatting
5f1fe2b Format code with prettier

📊 Changes

19 files changed (+1273 additions, -1113 deletions)

View changed files

➕ .prettierignore (+16 -0)
➕ .prettierrc (+3 -0)
📝 bun.lockb (+0 -0)
📝 docs/Contribute.md (+1 -1)
📝 internal/view/assets/css/archive.css (+1 -1)
📝 internal/view/assets/css/style.css (+1 -1)
📝 internal/view/assets/js/component/bookmark.js (+20 -23)
📝 internal/view/assets/js/component/dialog.js (+64 -53)
📝 internal/view/assets/js/component/pagination.js (+4 -4)
📝 internal/view/assets/js/page/base.js (+31 -21)
📝 internal/view/assets/js/page/home.js (+432 -344)
📝 internal/view/assets/js/page/setting.js (+169 -146)
📝 internal/view/assets/less/archive.less (+28 -28)
📝 internal/view/assets/less/bookmark-item.less (+98 -98)
📝 internal/view/assets/less/common.less (+295 -295)
📝 internal/view/assets/less/custom-dialog.less (+96 -97)
📝 package.json (+7 -1)
📝 scripts/styles.sh (+1 -0)
📝 scripts/styles_check.sh (+6 -0)

📄 Description

As discussed this draft is a suggestion to format frontend files to prevent a mix-up of tabs/spaces. Sadly c7ad3ffd42a599c86d8977d7058ee02660c340c3 is a rather large commit due to the configuration forcing streamlined line endings (and other things like indentation) to all less & js files.
I would understand if this is too large of a changeset for such a minor thing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/764 **Author:** [@cbe](https://github.com/cbe) **Created:** 10/17/2023 **Status:** ✅ Merged **Merged:** 11/5/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `frontend_formatting` --- ### 📝 Commits (9) - [`46ec50e`](https://github.com/go-shiori/shiori/commit/46ec50e116d7a11f5fab23cf07ab5d4602f57172) Install `prettier` - [`23881d5`](https://github.com/go-shiori/shiori/commit/23881d5a52559a9ff46af13b31c42d15ffc1af6f) Configure prettier - [`e2af5dc`](https://github.com/go-shiori/shiori/commit/e2af5dcf4e0fcd6af9bcaee5e68b7770903d69be) Check & format with prettier when compiling less - [`a099933`](https://github.com/go-shiori/shiori/commit/a0999332e12f73e2a3a29256a2ddf392148a1fb6) Update docs to use bun - [`f649720`](https://github.com/go-shiori/shiori/commit/f649720f2c0a97362df898b1aa16fbc832de329f) Check actual result of prettier - [`4c6eb19`](https://github.com/go-shiori/shiori/commit/4c6eb193862937d60680bb10f6eb49c7f9d70d8f) Use LF line endings - [`1676e5d`](https://github.com/go-shiori/shiori/commit/1676e5dcd108b9be3b2b6e54c142eb5f58cfb098) Limit prettier to `internal/view/` - [`38351bc`](https://github.com/go-shiori/shiori/commit/38351bc07dc110db92f1d60a10c1ead364a21ed2) Merge remote-tracking branch 'master' into frontend_formatting - [`5f1fe2b`](https://github.com/go-shiori/shiori/commit/5f1fe2be2db0462648752b3f907b028ac30289c0) Format code with prettier ### 📊 Changes **19 files changed** (+1273 additions, -1113 deletions) <details> <summary>View changed files</summary> ➕ `.prettierignore` (+16 -0) ➕ `.prettierrc` (+3 -0) 📝 `bun.lockb` (+0 -0) 📝 `docs/Contribute.md` (+1 -1) 📝 `internal/view/assets/css/archive.css` (+1 -1) 📝 `internal/view/assets/css/style.css` (+1 -1) 📝 `internal/view/assets/js/component/bookmark.js` (+20 -23) 📝 `internal/view/assets/js/component/dialog.js` (+64 -53) 📝 `internal/view/assets/js/component/pagination.js` (+4 -4) 📝 `internal/view/assets/js/page/base.js` (+31 -21) 📝 `internal/view/assets/js/page/home.js` (+432 -344) 📝 `internal/view/assets/js/page/setting.js` (+169 -146) 📝 `internal/view/assets/less/archive.less` (+28 -28) 📝 `internal/view/assets/less/bookmark-item.less` (+98 -98) 📝 `internal/view/assets/less/common.less` (+295 -295) 📝 `internal/view/assets/less/custom-dialog.less` (+96 -97) 📝 `package.json` (+7 -1) 📝 `scripts/styles.sh` (+1 -0) 📝 `scripts/styles_check.sh` (+6 -0) </details> ### 📄 Description As discussed this draft is a suggestion to format frontend files to prevent a mix-up of tabs/spaces. Sadly c7ad3ffd42a599c86d8977d7058ee02660c340c3 is a rather large commit due to the configuration forcing streamlined line endings (and other things like indentation) to all less & js files. I would understand if this is too large of a changeset for such a minor thing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>