[PR #807] [MERGED] fix: force usage of shiori prefix for environment variables in configuration #797

New issue

Closed

opened 2026-02-25 23:35:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/807
Author: @fmartingr
Created: 12/29/2023
Status: ✅ Merged
Merged: 12/29/2023
Merged by: @fmartingr

Base: master ← Head: fmartingr/issue787

📝 Commits (6)

ae9f3f3 fix: disable direct os lookuper
7fda7bc config.setdefaults call config.http.setdefaults
8914db7 tests
e1737f0 log level default in local run server
66cdf5a store log level in configuration
e6f9ff2 Merge branch 'master' into fmartingr/issue787

📊 Changes

5 files changed (+165 additions, -22 deletions)

View changed files

📝 Makefile (+1 -1)
📝 internal/cmd/root.go (+3 -0)
📝 internal/cmd/server.go (+0 -2)
📝 internal/config/config.go (+48 -19)
➕ internal/config/config_test.go (+113 -0)

📄 Description

Disable the configuration OS Lookuper to prevent errors when setting configuration via environment variables. All variables but HOSTNAME should use the SHIORI_ prefix.
Added tests coverage for the config.go file
Small refactor under Config.SetDefaults
With LOG_LEVEL=DEBUG, all the configuration variables are logged on server startup.

Fixes #787

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/807 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 12/29/2023 **Status:** ✅ Merged **Merged:** 12/29/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fmartingr/issue787` --- ### 📝 Commits (6) - [`ae9f3f3`](https://github.com/go-shiori/shiori/commit/ae9f3f3f151aef8043090773b76903c7dbcac2dc) fix: disable direct os lookuper - [`7fda7bc`](https://github.com/go-shiori/shiori/commit/7fda7bc2d97d15cf291c10cfc9294a31fba27cfa) config.setdefaults call config.http.setdefaults - [`8914db7`](https://github.com/go-shiori/shiori/commit/8914db7774a56336b159a13af6011512de3f2524) tests - [`e1737f0`](https://github.com/go-shiori/shiori/commit/e1737f0bc13853b3bdfec03d2e588500a2d82481) log level default in local run server - [`66cdf5a`](https://github.com/go-shiori/shiori/commit/66cdf5acfbd5e084e4c83d307dacdd3446449678) store log level in configuration - [`e6f9ff2`](https://github.com/go-shiori/shiori/commit/e6f9ff2b3b9224e987f827a9f34a90f8e766e3cf) Merge branch 'master' into fmartingr/issue787 ### 📊 Changes **5 files changed** (+165 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+1 -1) 📝 `internal/cmd/root.go` (+3 -0) 📝 `internal/cmd/server.go` (+0 -2) 📝 `internal/config/config.go` (+48 -19) ➕ `internal/config/config_test.go` (+113 -0) </details> ### 📄 Description - Disable the configuration OS Lookuper to prevent errors when setting configuration via environment variables. All variables but `HOSTNAME` should use the `SHIORI_` prefix. - Added tests coverage for the `config.go` file - Small refactor under `Config.SetDefaults` - With `LOG_LEVEL=DEBUG`, all the configuration variables are logged on server startup. Fixes #787 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>