[GH-ISSUE #302] Add bookmarks asynchronously #222

New issue

Closed

opened 2026-02-25 23:33:44 +03:00 by kerem · 2 comments

kerem commented

2026-02-25 23:33:44 +03:00

Owner

Originally created by @amitjethani on GitHub (Mar 10, 2021).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/302

I have some feedback on making the API leaner and asynchronous:

If I invoke POST {{host}}/api/bookmarks with the body

	"url": "https://www.nytimes.com/2021/03/10/nyregion/nyc-jail-covid.html",
        "createArchive": true

The response takes approximately 57 seconds. In my opinion, the API should respond back with a 200 OK immediately, and schedule an async task to fetch the archive.

An alternative could be that a nightly job can be scheduled that can fetch archives of unarchived links. In this way, submitting a new bookmark is always a quick operation.

Originally created by @amitjethani on GitHub (Mar 10, 2021). Original GitHub issue: https://github.com/go-shiori/shiori/issues/302 I have some feedback on making the API leaner and asynchronous: If I invoke `POST {{host}}/api/bookmarks` with the body ```json "url": "https://www.nytimes.com/2021/03/10/nyregion/nyc-jail-covid.html", "createArchive": true ``` The response takes approximately 57 seconds. In my opinion, the API should respond back with a 200 OK immediately, and schedule an async task to fetch the archive. An alternative could be that a nightly job can be scheduled that can fetch archives of unarchived links. In this way, submitting a new bookmark is always a quick operation.

kerem

2026-02-25 23:33:44 +03:00

closed this issue
added the
type:enhancement

component:frontend

priority:low

component:backend
labels

kerem commented

2026-02-25 23:33:44 +03:00

Author

Owner

@clach04 commented on GitHub (Jun 20, 2021):

I would prefer the behavior not change. I do like the asynchronous idea, recommend asynchronous if provided payload has an asynchronous key present.

@clach04 commented on GitHub (Jun 20, 2021): I would prefer the behavior not change. I do like the asynchronous idea, recommend asynchronous if provided payload has an asynchronous key present.

kerem commented

2026-02-25 23:33:44 +03:00

Author

Owner

@amitjethani commented on GitHub (Jun 20, 2021):

That’s a good idea, an additional query parameter such as async: true could make this optional.

@amitjethani commented on GitHub (Jun 20, 2021): That’s a good idea, an additional query parameter such as `async: true` could make this optional.

kerem referenced this issue

2026-02-25 23:34:39 +03:00

[PR #221] [MERGED] Fix login autofill #538