[PR #2911] [MERGED] fix rough mouse movement due to incorrect check #3074

Closed
opened 2026-02-27 22:02:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2911
Author: @ringolol
Created: 5/12/2025
Status: Merged
Merged: 5/12/2025
Merged by: @kalaposfos13

Base: mainHead: main


📝 Commits (1)

  • 5567ed6 fix rough mouse movement due to incorrect check

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/input/input_mouse.cpp (+1 -1)

📄 Description

Hey! I was having problems playing BB on a mouse, the movement was too rough, especially when i was trying to move mouse slowly.

Found a strange check in the mouse handler. When the mouse is moved perfectly horizontally or vertically, the controller values are not updated.

Perhaps its better to use OR here? That solved the problems for me, now the mouse movements are pretty smooth


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2911 **Author:** [@ringolol](https://github.com/ringolol) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@kalaposfos13](https://github.com/kalaposfos13) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`5567ed6`](https://github.com/shadps4-emu/shadPS4/commit/5567ed6623d035d917700e73a072c39d31772d21) fix rough mouse movement due to incorrect check ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/input/input_mouse.cpp` (+1 -1) </details> ### 📄 Description Hey! I was having problems playing BB on a mouse, the movement was too rough, especially when i was trying to move mouse slowly. Found a strange check in the mouse handler. When the mouse is moved perfectly horizontally or vertically, the controller values are not updated. Perhaps its better to use OR here? That solved the problems for me, now the mouse movements are pretty smooth --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:02:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3074
No description provided.