[PR #3074] [MERGED] vulkan: Fix two validation errors introduced by shared memory changes. #3200

New issue

Closed

opened 2026-02-27 22:02:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3074
Author: @squidbus
Created: 6/10/2025
Status: ✅ Merged
Merged: 6/10/2025
Merged by: @squidbus

Base: main ← Head: fix-shared

📝 Commits (1)

c66191f vulkan: Fix two validation errors introduced by shared memory changes.

📊 Changes

2 files changed (+23 additions, -5 deletions)

View changed files

📝 src/shader_recompiler/ir/passes/shared_memory_to_storage_pass.cpp (+4 -4)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+19 -1)

📄 Description

Fix LDS buffer of size 0 being bound when shared memory is not needed by a shader and VK_KHR_workgroup_memory_explicit_layout is not supported.
Fix extra feature structs being included in device create chain due to re-using portability subset feature instance without it being last in the get chain.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3074 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 6/10/2025 **Status:** ✅ Merged **Merged:** 6/10/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `fix-shared` --- ### 📝 Commits (1) - [`c66191f`](https://github.com/shadps4-emu/shadPS4/commit/c66191fb4ba196079a827e2c9413eff4a944f853) vulkan: Fix two validation errors introduced by shared memory changes. ### 📊 Changes **2 files changed** (+23 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/ir/passes/shared_memory_to_storage_pass.cpp` (+4 -4) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+19 -1) </details> ### 📄 Description * Fix LDS buffer of size 0 being bound when shared memory is not needed by a shader and `VK_KHR_workgroup_memory_explicit_layout` is not supported. * Fix extra feature structs being included in device create chain due to re-using portability subset feature instance without it being last in the get chain. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>