[PR #2688] [MERGED] Fixed undefined behavior in how allInstallDirsDisabled is determined #2911

New issue

Closed

opened 2026-02-27 22:01:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2688
Author: @k3dr1
Created: 3/26/2025
Status: ✅ Merged
Merged: 3/26/2025
Merged by: @georgemoralis

Base: main ← Head: main

📝 Commits (1)

f1b8dff Slightly changed how allInstallDirsDisabled is determined

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 src/qt_gui/main.cpp (+1 -2)

📄 Description

There was undefined behavior due to incompatible iterators from two different temp values being passed to std::all_of. This PR fixes that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2688 **Author:** [@k3dr1](https://github.com/k3dr1) **Created:** 3/26/2025 **Status:** ✅ Merged **Merged:** 3/26/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`f1b8dff`](https://github.com/shadps4-emu/shadPS4/commit/f1b8dff87f2c4a3c6d991e8442652e18ca8e3266) Slightly changed how allInstallDirsDisabled is determined ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/main.cpp` (+1 -2) </details> ### 📄 Description There was undefined behavior due to incompatible iterators from two different temp values being passed to std::all_of. This PR fixes that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>