[PR #1080] [MERGED] Fix build on GCC #1918

Closed
opened 2026-02-27 21:14:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1080
Author: @OFFTKP
Created: 9/26/2024
Status: Merged
Merged: 9/26/2024
Merged by: @raphaelthegreat

Base: mainHead: gcc2


📝 Commits (3)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/video_core/texture_cache/tile_manager.cpp (+1 -1)

📄 Description

Would cause weird compiler bug on GCC, was reported on issue #1072 which was deleted

in gimple_add_tmp_var, at gimplify.cc:802
  298 |         static auto [desc_layout_result, desc_layout] =
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0x21a922a internal_error(char const*, ...)
        ???:0
0x704ec1 fancy_abort(char const*, int, char const*)
        ???:0
0xc57884 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc56969 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc57cf5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc57cf5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc57cf5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc56969 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc57cf5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int)
        ???:0
0xc5cb4b gimplify_body(tree_node*, bool)
        ???:0
0xc5d04c gimplify_function_tree(tree_node*)
        ???:0
0xa9861b cgraph_node::analyze()
        ???:0
0xaa6eb9 symbol_table::finalize_compilation_unit()
        ???:0

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1080 **Author:** [@OFFTKP](https://github.com/OFFTKP) **Created:** 9/26/2024 **Status:** ✅ Merged **Merged:** 9/26/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `gcc2` --- ### 📝 Commits (3) - [`849367b`](https://github.com/shadps4-emu/shadPS4/commit/849367baa8d9843061aac987aa7304926101646e) Fix build on GCC - [`1d079d8`](https://github.com/shadps4-emu/shadPS4/commit/1d079d817807b7b34997fc309fd51bf39f7598af) Yes thank you clang-format - [`262b457`](https://github.com/shadps4-emu/shadPS4/commit/262b4577ccf7e2bdb658c722c5341f12353c5a2c) Just remove static ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/tile_manager.cpp` (+1 -1) </details> ### 📄 Description Would cause weird compiler bug on GCC, was reported on issue #1072 which was deleted ``` in gimple_add_tmp_var, at gimplify.cc:802 298 | static auto [desc_layout_result, desc_layout] = | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 0x21a922a internal_error(char const*, ...) ???:0 0x704ec1 fancy_abort(char const*, int, char const*) ???:0 0xc57884 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc56969 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc57cf5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc57cf5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc57cf5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc56969 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc57cf5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc577f5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ???:0 0xc5cb4b gimplify_body(tree_node*, bool) ???:0 0xc5d04c gimplify_function_tree(tree_node*) ???:0 0xa9861b cgraph_node::analyze() ???:0 0xaa6eb9 symbol_table::finalize_compilation_unit() ???:0 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:14:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#1918
No description provided.