mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 08:15:59 +03:00
[PR #748] [MERGED] vulkan: Better support for directly linking a Vulkan support library. #1749
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#1749
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/748
Author: @squidbus
Created: 9/3/2024
Status: ✅ Merged
Merged: 9/3/2024
Merged by: @georgemoralis
Base:
main← Head:vk-loading📝 Commits (1)
af107d4vulkan: Better support for directly linking a Vulkan support library.📊 Changes
6 files changed (+37 additions, -17 deletions)
View changed files
📝
CMakeLists.txt(+9 -4)📝
src/video_core/renderer_vulkan/vk_common.h(+4 -0)📝
src/video_core/renderer_vulkan/vk_instance.cpp(+2 -2)📝
src/video_core/renderer_vulkan/vk_instance.h(+0 -7)📝
src/video_core/renderer_vulkan/vk_platform.cpp(+20 -2)📝
src/video_core/renderer_vulkan/vk_platform.h(+2 -2)📄 Description
Some enhancements for cases like MoltenVK where a Vulkan support library is directly linked. Allows for disabling the part of vulkan-hpp that loads the library from a file with
dlopen, instead using thevkGetInstanceProcAddrthat is already linked in.This helps with development builds as you no longer need to make sure that the MoltenVK path is in the dynamic link library path at runtime, plus it just cuts some waste from loading a library that's already linked.
I've also added an override
USE_SYSTEM_VULKAN_LOADERfor Mac as if you have the full SDK installed it's useful to be able to load validation layers for debugging.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.