[PR #748] [MERGED] vulkan: Better support for directly linking a Vulkan support library. #1749

Closed
opened 2026-02-27 21:13:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/748
Author: @squidbus
Created: 9/3/2024
Status: Merged
Merged: 9/3/2024
Merged by: @georgemoralis

Base: mainHead: vk-loading


📝 Commits (1)

  • af107d4 vulkan: Better support for directly linking a Vulkan support library.

📊 Changes

6 files changed (+37 additions, -17 deletions)

View changed files

📝 CMakeLists.txt (+9 -4)
📝 src/video_core/renderer_vulkan/vk_common.h (+4 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+2 -2)
📝 src/video_core/renderer_vulkan/vk_instance.h (+0 -7)
📝 src/video_core/renderer_vulkan/vk_platform.cpp (+20 -2)
📝 src/video_core/renderer_vulkan/vk_platform.h (+2 -2)

📄 Description

Some enhancements for cases like MoltenVK where a Vulkan support library is directly linked. Allows for disabling the part of vulkan-hpp that loads the library from a file with dlopen, instead using the vkGetInstanceProcAddr that is already linked in.

This helps with development builds as you no longer need to make sure that the MoltenVK path is in the dynamic link library path at runtime, plus it just cuts some waste from loading a library that's already linked.

I've also added an override USE_SYSTEM_VULKAN_LOADER for Mac as if you have the full SDK installed it's useful to be able to load validation layers for debugging.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/748 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/3/2024 **Status:** ✅ Merged **Merged:** 9/3/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `vk-loading` --- ### 📝 Commits (1) - [`af107d4`](https://github.com/shadps4-emu/shadPS4/commit/af107d4ef98c54c6660c3f7677208def55b02e27) vulkan: Better support for directly linking a Vulkan support library. ### 📊 Changes **6 files changed** (+37 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+9 -4) 📝 `src/video_core/renderer_vulkan/vk_common.h` (+4 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+2 -2) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+0 -7) 📝 `src/video_core/renderer_vulkan/vk_platform.cpp` (+20 -2) 📝 `src/video_core/renderer_vulkan/vk_platform.h` (+2 -2) </details> ### 📄 Description Some enhancements for cases like MoltenVK where a Vulkan support library is directly linked. Allows for disabling the part of vulkan-hpp that loads the library from a file with `dlopen`, instead using the `vkGetInstanceProcAddr` that is already linked in. This helps with development builds as you no longer need to make sure that the MoltenVK path is in the dynamic link library path at runtime, plus it just cuts some waste from loading a library that's already linked. I've also added an override `USE_SYSTEM_VULKAN_LOADER` for Mac as if you have the full SDK installed it's useful to be able to load validation layers for debugging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:13:48 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#1749
No description provided.