[PR #1749] [MERGED] renderer_vulkan: Disable culling for RectList. #2276

New issue

Closed

opened 2026-02-27 21:15:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1749
Author: @squidbus
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/12/2024
Merged by: @georgemoralis

Base: main ← Head: rectlist-cull

📝 Commits (1)

533bc6c renderer_vulkan: Disable culling for RectList.

📊 Changes

3 files changed (+32 additions, -1 deletions)

View changed files

📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+27 -0)
📝 src/video_core/renderer_vulkan/liverpool_to_vk.h (+2 -0)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+3 -1)

📄 Description

As far as I can tell from testing and looking through what documentation I could find, it appears RectList primitives should not be culled. Added a utility for determining whether a primitive type is subject to culling, and disabled culling if so.

Fixes rendering of a lot of UI and 2D menus in Sonic Forces.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1749 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/12/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `rectlist-cull` --- ### 📝 Commits (1) - [`533bc6c`](https://github.com/shadps4-emu/shadPS4/commit/533bc6c6f099f4ea364a6debeb7064770e70278c) renderer_vulkan: Disable culling for RectList. ### 📊 Changes **3 files changed** (+32 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+27 -0) 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.h` (+2 -0) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+3 -1) </details> ### 📄 Description As far as I can tell from testing and looking through what documentation I could find, it appears `RectList` primitives should not be culled. Added a utility for determining whether a primitive type is subject to culling, and disabled culling if so. Fixes rendering of a lot of UI and 2D menus in Sonic Forces. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>